Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 974113002: Subzero: Rerun clang-format after LLVM 3.6 merge. (Closed)

Created:
5 years, 9 months ago by Jim Stichnoth
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -207 lines) Patch
M crosstest/test_arith_main.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M crosstest/test_bitmanip_main.cpp View 3 chunks +15 lines, -28 lines 2 comments Download
M crosstest/test_calling_conv_main.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M crosstest/test_cast_main.cpp View 1 chunk +10 lines, -20 lines 0 comments Download
M crosstest/test_fcmp_main.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M crosstest/test_global.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M crosstest/test_icmp_main.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M crosstest/test_sync_atomic_main.cpp View 3 chunks +15 lines, -25 lines 0 comments Download
M src/IceELFObjectWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInst.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/IceInstX8632.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/IceIntrinsics.cpp View 8 chunks +69 lines, -72 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/main.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 9 months ago (2015-03-04 00:17:11 UTC) #2
jvoung (off chromium)
lgtm https://codereview.chromium.org/974113002/diff/1/crosstest/test_bitmanip_main.cpp File crosstest/test_bitmanip_main.cpp (right): https://codereview.chromium.org/974113002/diff/1/crosstest/test_bitmanip_main.cpp#newcode31 crosstest/test_bitmanip_main.cpp:31: 0, 1, 0x7e, 0x7f, 0x80, 0x81, 0xfe, 0xff, ...
5 years, 9 months ago (2015-03-04 00:57:52 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/974113002/diff/1/crosstest/test_bitmanip_main.cpp File crosstest/test_bitmanip_main.cpp (right): https://codereview.chromium.org/974113002/diff/1/crosstest/test_bitmanip_main.cpp#newcode31 crosstest/test_bitmanip_main.cpp:31: 0, 1, 0x7e, 0x7f, 0x80, 0x81, 0xfe, 0xff, 0x7ffe, ...
5 years, 9 months ago (2015-03-04 01:06:10 UTC) #4
Jim Stichnoth
5 years, 9 months ago (2015-03-04 01:06:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d9dc82e4168ff4ed29857f7d970ee3fa4e172245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698