[Extensions] Make chrome://extensions use developerPrivate for error calls

[Extensions] Make chrome://extensions use developerPrivate for error calls

Make the chrome://extensions page use chrome.developerPrivate API for
extension error-related functionality.
Also add tests for the api function, and convert it to a
UIThreadExtensionFunction.

Additionally, fix a bug in extensions.js where calling "showOverlay" on an
already-visible hid the overlay (temporarily).

BUG=461039
Committed: https://crrev.com/01332dbdf70785e2dd112cc109b2c7c1205402d7
Cr-Commit-Position: refs/heads/master@{#319661}

[Devlin, 2015-03-03 23:11:01]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-03-04 00:11:27]

sweet, lgtm.

https://codereview.chromium.org/973303002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/973303002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:182:
base::ReadFileToString(path, &data);
Wrap this in ignore_result().

https://codereview.chromium.org/973303002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.js (right):

https://codereview.chromium.org/973303002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.js:355: * Sets the given overlay
to show. This hides whatever overlay is currently
A no-op if |node| is already showing, otherwise hides whatever...

[Devlin, 2015-03-04 18:05:25]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org

[Devlin, 2015-03-04 18:05:26]

Dan, wanna take a quick look at the JS?

https://codereview.chromium.org/973303002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/973303002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:182:
base::ReadFileToString(path, &data);
On 2015/03/04 00:11:27, kalman wrote:
> Wrap this in ignore_result().

Done.

https://codereview.chromium.org/973303002/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extensions.js (right):

https://codereview.chromium.org/973303002/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extensions.js:355: * Sets the given overlay
to show. This hides whatever overlay is currently
On 2015/03/04 00:11:27, kalman wrote:
> A no-op if |node| is already showing, otherwise hides whatever...

Done.

[Dan Beam, 2015-03-05 02:05:12]

https://codereview.chromium.org/973303002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_error_overlay.js (right):

https://codereview.chromium.org/973303002/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_error_overlay.js:488: textContent
= response.title;
if response can be null, shouldn't we handle that case?

[Dan Beam, 2015-03-05 02:05:46]

https://codereview.chromium.org/973303002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_error_overlay.js (right):

https://codereview.chromium.org/973303002/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_error_overlay.js:464:
this.onFileSourceResponse_(null);
doesn't this throw a null pointer exception, basically?

[Devlin, 2015-03-05 16:56:17]

https://codereview.chromium.org/973303002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/extensions/extension_error_overlay.js (right):

https://codereview.chromium.org/973303002/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_error_overlay.js:464:
this.onFileSourceResponse_(null);
On 2015/03/05 02:05:46, Dan Beam wrote:
> doesn't this throw a null pointer exception, basically?

Yes. Fixed.

https://codereview.chromium.org/973303002/diff/20001/chrome/browser/resources...
chrome/browser/resources/extensions/extension_error_overlay.js:488: textContent
= response.title;
On 2015/03/05 02:05:12, Dan Beam wrote:
> if response can be null, shouldn't we handle that case?

Yes, we definitely should.

[Dan Beam, 2015-03-06 21:47:52]

lgtm

[Devlin, 2015-03-09 16:05:46]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-03-09 16:05:46]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/973303002/#ps80001 (title:
"Latest master")

[commit-bot: I haz the power, 2015-03-09 16:06:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973303002/80001

[commit-bot: I haz the power, 2015-03-09 17:16:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-09 17:17:30]

Patchset 5 (id:??) landed as
https://crrev.com/01332dbdf70785e2dd112cc109b2c7c1205402d7
Cr-Commit-Position: refs/heads/master@{#319661}