chrome/browser/resources/extensions/extensions.js - Issue 973303002: [Extensions] Make chrome://extensions use developerPrivate for error calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 973303002: [Extensions] Make chrome://extensions use developerPrivate for error calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_error_overlay.js ('k') | chrome/browser/ui/webui/extensions/extension_error_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extensions.js

diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js

index 6500f07cbf32e1035b53ec1bb74840eeeb161c3a..f211a968f5e1eac666b065ae77d9fb38edcb0335 100644

--- a/chrome/browser/resources/extensions/extensions.js

+++ b/chrome/browser/resources/extensions/extensions.js

@@ -352,8 +352,8 @@ cr.define('extensions', function() {

};

/**

- * Sets the given overlay to show. This hides whatever overlay is currently

- * showing, if any.

+ * Sets the given overlay to show. If the overlay is already showing, this is

+ * a no-op; otherwise, hides any currently-showing overlay.

* @param {HTMLElement} node The overlay page to show. If null, all overlays

* are hidden.

@@ -364,6 +364,8 @@ cr.define('extensions', function() {

var currentlyShowingOverlay = ExtensionSettings.getCurrentOverlay();

if (currentlyShowingOverlay) {

+ if (currentlyShowingOverlay == node) // Already displayed.

+ return;

currentlyShowingOverlay.classList.remove('showing');

cr.dispatchSimpleEvent($('overlay'), 'cancelOverlay');

}