Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 973303002: [Extensions] Make chrome://extensions use developerPrivate for error calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/saved_files_service.h" 8 #include "apps/saved_files_service.h"
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/base64.h" 10 #include "base/base64.h"
(...skipping 642 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_PRIVATE_KEY_LABEL)); 653 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_PRIVATE_KEY_LABEL));
654 source->AddString("packExtensionBrowseButton", 654 source->AddString("packExtensionBrowseButton",
655 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_BROWSE)); 655 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_DIALOG_BROWSE));
656 source->AddString("packExtensionProceedAnyway", 656 source->AddString("packExtensionProceedAnyway",
657 l10n_util::GetStringUTF16(IDS_EXTENSION_PROCEED_ANYWAY)); 657 l10n_util::GetStringUTF16(IDS_EXTENSION_PROCEED_ANYWAY));
658 source->AddString("packExtensionWarningTitle", 658 source->AddString("packExtensionWarningTitle",
659 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_WARNING_TITLE)); 659 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_WARNING_TITLE));
660 source->AddString("packExtensionErrorTitle", 660 source->AddString("packExtensionErrorTitle",
661 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_ERROR_TITLE)); 661 l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_ERROR_TITLE));
662 662
663 // Extension Error and Extension Error Overlay:
664 source->AddString(
665 "extensionErrorsShowMore",
666 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERRORS_SHOW_MORE));
667 source->AddString(
668 "extensionErrorsShowFewer",
669 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERRORS_SHOW_FEWER));
670 source->AddString(
671 "extensionErrorViewDetails",
672 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_VIEW_DETAILS));
673 source->AddString(
674 "extensionErrorViewManifest",
675 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_VIEW_MANIFEST));
676 source->AddString("extensionErrorOverlayDone",
677 l10n_util::GetStringUTF16(IDS_DONE));
678 source->AddString(
679 "extensionErrorOverlayContextUrl",
680 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_CONTEXT));
681 source->AddString(
682 "extensionErrorOverlayStackTrace",
683 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_STACK_TRACE));
684 source->AddString(
685 "extensionErrorOverlayAnonymousFunction",
686 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_ANONYMOUS_FUNCTION));
687 source->AddString(
688 "extensionErrorOverlayLaunchDevtools",
689 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_LAUNCH_DEVTOOLS));
690 source->AddString(
691 "extensionErrorOverlayContextUnknown",
692 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_CONTEXT_UNKNOWN));
693 source->AddString(
694 "extensionErrorOverlayNoCodeToDisplay",
695 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_NO_CODE_TO_DISPLAY));
663 } 696 }
664 697
665 void ExtensionSettingsHandler::RenderViewDeleted( 698 void ExtensionSettingsHandler::RenderViewDeleted(
666 RenderViewHost* render_view_host) { 699 RenderViewHost* render_view_host) {
667 deleting_rvh_ = render_view_host; 700 deleting_rvh_ = render_view_host;
668 Profile* source_profile = Profile::FromBrowserContext( 701 Profile* source_profile = Profile::FromBrowserContext(
669 render_view_host->GetSiteInstance()->GetBrowserContext()); 702 render_view_host->GetSiteInstance()->GetBrowserContext());
670 if (!Profile::FromWebUI(web_ui())->IsSameProfile(source_profile)) 703 if (!Profile::FromWebUI(web_ui())->IsSameProfile(source_profile))
671 return; 704 return;
672 MaybeUpdateAfterNotification(); 705 MaybeUpdateAfterNotification();
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
1339 } 1372 }
1340 1373
1341 void ExtensionSettingsHandler::OnReinstallComplete( 1374 void ExtensionSettingsHandler::OnReinstallComplete(
1342 bool success, 1375 bool success,
1343 const std::string& error, 1376 const std::string& error,
1344 webstore_install::Result result) { 1377 webstore_install::Result result) {
1345 MaybeUpdateAfterNotification(); 1378 MaybeUpdateAfterNotification();
1346 } 1379 }
1347 1380
1348 } // namespace extensions 1381 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_error_ui_util.cc ('k') | chrome/browser/ui/webui/extensions/extensions_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698