chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 973303002: [Extensions] Make chrome://extensions use developerPrivate for error calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 973303002: [Extensions] Make chrome://extensions use developerPrivate for error calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_error_ui_util.cc ('k') | chrome/browser/ui/webui/extensions/extensions_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index c21555f79563f938d677a3d36b9c1946196fd9d5..c1cd9673cb913fbf7f6e4d82dd0fa3b86ee95239 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -660,6 +660,39 @@ void ExtensionSettingsHandler::GetLocalizedValues(

source->AddString("packExtensionErrorTitle",

l10n_util::GetStringUTF16(IDS_EXTENSION_PACK_ERROR_TITLE));

+ // Extension Error and Extension Error Overlay:

+ source->AddString(

+ "extensionErrorsShowMore",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERRORS_SHOW_MORE));

+ source->AddString(

+ "extensionErrorsShowFewer",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERRORS_SHOW_FEWER));

+ source->AddString(

+ "extensionErrorViewDetails",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_VIEW_DETAILS));

+ source->AddString(

+ "extensionErrorViewManifest",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_VIEW_MANIFEST));

+ source->AddString("extensionErrorOverlayDone",

+ l10n_util::GetStringUTF16(IDS_DONE));

+ source->AddString(

+ "extensionErrorOverlayContextUrl",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_CONTEXT));

+ source->AddString(

+ "extensionErrorOverlayStackTrace",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_STACK_TRACE));

+ source->AddString(

+ "extensionErrorOverlayAnonymousFunction",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_ANONYMOUS_FUNCTION));

+ source->AddString(

+ "extensionErrorOverlayLaunchDevtools",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_LAUNCH_DEVTOOLS));

+ source->AddString(

+ "extensionErrorOverlayContextUnknown",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_CONTEXT_UNKNOWN));

+ source->AddString(

+ "extensionErrorOverlayNoCodeToDisplay",

+ l10n_util::GetStringUTF16(IDS_EXTENSIONS_ERROR_NO_CODE_TO_DISPLAY));

}

void ExtensionSettingsHandler::RenderViewDeleted(