Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 973173002: Switch rasterize_and_record_micro measurement to use RunPageInteractions (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
Reviewers:
sullivan, sh
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch rasterize_and_record_micro measurement to use RunPageInteractions. After https://codereview.chromium.org/966283002, https://codereview.chromium.org/926213002, https://codereview.chromium.org/927763002, all the pages used with raterize_and_record_micro do not issue any interactions in RunPageInteractions method, should this change should not cause any functional changes to how the pages get run. BUG=418375 Committed: https://crrev.com/e6121de759fd6a262c749f12266efcc8d7b1c953 Cr-Commit-Position: refs/heads/master@{#318943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M tools/perf/measurements/measurement_smoke_test.py View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
+Simon: in situation like this, I would like to run all the rasterize_and_record_micro benchmarks on ...
5 years, 9 months ago (2015-03-03 20:21:16 UTC) #2
sullivan
lgtm
5 years, 9 months ago (2015-03-03 20:25:20 UTC) #3
shatch
On 2015/03/03 20:21:16, nednguyen wrote: > +Simon: in situation like this, I would like to ...
5 years, 9 months ago (2015-03-03 20:27:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973173002/1
5 years, 9 months ago (2015-03-03 20:31:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 21:30:53 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 21:31:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6121de759fd6a262c749f12266efcc8d7b1c953
Cr-Commit-Position: refs/heads/master@{#318943}

Powered by Google App Engine
This is Rietveld 408576698