Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 926213002: [Telemetry] Add run_no_page_interactions options to polymer page. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu, vmiura
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add run_no_page_interactions options to polymer page. This is to prepare for switching rasterize_and_micro_record's action_name_to_run from empty string to 'RunPageInteractions'. BUG=418375 Committed: https://crrev.com/05140bce74b348034509f87b672ce9710f129af5 Cr-Commit-Position: refs/heads/master@{#316490}

Patch Set 1 #

Total comments: 1

Patch Set 2 : s/KeySilkCasesPage/PolymerPage/ #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -16 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 1 chunk +3 lines, -1 line 2 comments Download
M tools/perf/page_sets/polymer.py View 1 9 chunks +43 lines, -15 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
nednguyen
5 years, 10 months ago (2015-02-14 00:02:43 UTC) #2
sullivan
lgtm https://codereview.chromium.org/926213002/diff/1/tools/perf/page_sets/polymer.py File tools/perf/page_sets/polymer.py (right): https://codereview.chromium.org/926213002/diff/1/tools/perf/page_sets/polymer.py#newcode265 tools/perf/page_sets/polymer.py:265: 'Pages in this page set must not override ...
5 years, 10 months ago (2015-02-16 02:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926213002/20001
5 years, 10 months ago (2015-02-16 16:04:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-16 17:08:06 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/05140bce74b348034509f87b672ce9710f129af5 Cr-Commit-Position: refs/heads/master@{#316490}
5 years, 10 months ago (2015-02-16 17:08:49 UTC) #8
sullivan
https://codereview.chromium.org/926213002/diff/20001/tools/perf/benchmarks/rasterize_and_record_micro.py File tools/perf/benchmarks/rasterize_and_record_micro.py (right): https://codereview.chromium.org/926213002/diff/20001/tools/perf/benchmarks/rasterize_and_record_micro.py#newcode93 tools/perf/benchmarks/rasterize_and_record_micro.py:93: return page_sets.PolymerPageSet(run_no_page_interactions=True) Looks like run_no_page_interactions should have been False ...
5 years, 10 months ago (2015-02-18 01:07:15 UTC) #9
vmiura
5 years, 10 months ago (2015-02-18 01:18:37 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/926213002/diff/20001/tools/perf/benchmarks/ra...
File tools/perf/benchmarks/rasterize_and_record_micro.py (right):

https://codereview.chromium.org/926213002/diff/20001/tools/perf/benchmarks/ra...
tools/perf/benchmarks/rasterize_and_record_micro.py:93: return
page_sets.PolymerPageSet(run_no_page_interactions=True)
On 2015/02/18 01:07:15, sullivan wrote:
> Looks like run_no_page_interactions should have been False here. I am really
> sorry I missed this!

I'm not sure this is the bug.  Isn't this setting True on purpose?

https://codereview.chromium.org/926213002/diff/20001/tools/perf/page_sets/pol...
File tools/perf/page_sets/polymer.py (right):

https://codereview.chromium.org/926213002/diff/20001/tools/perf/page_sets/pol...
tools/perf/page_sets/polymer.py:26: def RunPageInteraction(self, action_runner):
Shouldn't this be "RunPageInteractions"?

Powered by Google App Engine
This is Rietveld 408576698