Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 966283002: [Telemetry] Change rasterize_and_record_micro to use top_25_pages page set. (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Change rasterize_and_record_micro to use top_25_pages page set. Add top_25_smooth.json as archive_data_file for top_25_smooth page set. top_25_pages page set uses top_25.json. BUG=418375 Committed: https://crrev.com/636ee5e280e63d5ad63ef0f5cf891840d0e2864a Cr-Commit-Position: refs/heads/master@{#318711}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update Top25Pages' docstring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/perf/page_sets/data/top_25_smooth.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/perf/page_sets/top_25_pages.py View 1 1 chunk +59 lines, -0 lines 0 comments Download
M tools/perf/page_sets/top_25_smooth.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
nednguyen
5 years, 9 months ago (2015-03-02 02:17:43 UTC) #2
sullivan
https://codereview.chromium.org/966283002/diff/1/tools/perf/page_sets/top_25_pages.py File tools/perf/page_sets/top_25_pages.py (right): https://codereview.chromium.org/966283002/diff/1/tools/perf/page_sets/top_25_pages.py#newcode12 tools/perf/page_sets/top_25_pages.py:12: """ Pages hand-picked for 2012 CrOS scrolling tuning efforts. ...
5 years, 9 months ago (2015-03-02 14:23:01 UTC) #3
nednguyen
https://codereview.chromium.org/966283002/diff/1/tools/perf/page_sets/top_25_pages.py File tools/perf/page_sets/top_25_pages.py (right): https://codereview.chromium.org/966283002/diff/1/tools/perf/page_sets/top_25_pages.py#newcode12 tools/perf/page_sets/top_25_pages.py:12: """ Pages hand-picked for 2012 CrOS scrolling tuning efforts. ...
5 years, 9 months ago (2015-03-02 15:35:54 UTC) #4
sullivan
On 2015/03/02 15:35:54, nednguyen wrote: > https://codereview.chromium.org/966283002/diff/1/tools/perf/page_sets/top_25_pages.py > File tools/perf/page_sets/top_25_pages.py (right): > > https://codereview.chromium.org/966283002/diff/1/tools/perf/page_sets/top_25_pages.py#newcode12 > ...
5 years, 9 months ago (2015-03-02 15:47:33 UTC) #5
sullivan
lgtm
5 years, 9 months ago (2015-03-02 15:47:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966283002/20001
5 years, 9 months ago (2015-03-02 16:10:21 UTC) #8
nednguyen
On 2015/03/02 15:47:33, sullivan wrote: > On 2015/03/02 15:35:54, nednguyen wrote: > > > https://codereview.chromium.org/966283002/diff/1/tools/perf/page_sets/top_25_pages.py ...
5 years, 9 months ago (2015-03-02 16:10:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 17:04:25 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:05:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/636ee5e280e63d5ad63ef0f5cf891840d0e2864a
Cr-Commit-Position: refs/heads/master@{#318711}

Powered by Google App Engine
This is Rietveld 408576698