Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 972833004: Revert of gpu: introduce glCopySubTextureCHROMIUM (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: introduce glCopySubTextureCHROMIUM (patchset #4 id:80001 of https://codereview.chromium.org/864513004/) Reason for revert: This broke telemetry_unittests and content_browsertests on Mac (see issue 463439) Original issue's description: > gpu: introduce glCopySubTextureCHROMIUM > > Introduce glCopySubTextureCHROMIUM to support immutable texture as well as to > optimize WebGL texSubImage2D(video | canvas). > > This CL changes gl_renderer to use glCopySubTextureCHROMIUM because the > destination texture is immutable. > > TEST=GLCopyTextureCHROMIUMTest > BUG=443151 > > Committed: https://crrev.com/fac6a2d44323ad51429ee728e241fe22242f5ebd > Cr-Commit-Position: refs/heads/master@{#318855} TBR=sievers@chromium.org,piman@chromium.org,kbr@chromium.org,zmo@chromium.org,scherkus@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=443151 Committed: https://crrev.com/d8dd1b60962d234c304585028a36fd8896601420 Cr-Commit-Position: refs/heads/master@{#318858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -1179 lines) Patch
M cc/resources/resource_provider.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +3 lines, -14 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt View 2 chunks +9 lines, -41 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 chunk +7 lines, -23 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 chunk +2 lines, -24 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 1 chunk +2 lines, -33 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +2 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +2 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +1 line, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +5 lines, -19 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +3 lines, -14 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +1 line, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +2 lines, -10 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 4 chunks +14 lines, -67 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +7 lines, -22 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +35 lines, -36 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 3 chunks +2 lines, -46 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 12 chunks +38 lines, -158 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 12 chunks +100 lines, -255 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 2 chunks +3 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 27 chunks +65 lines, -280 lines 0 comments Download
M gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/skcanvas_video_renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/skcanvas_video_renderer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Created Revert of gpu: introduce glCopySubTextureCHROMIUM
5 years, 9 months ago (2015-03-03 10:12:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972833004/1
5 years, 9 months ago (2015-03-03 10:13:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 10:14:42 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 10:15:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8dd1b60962d234c304585028a36fd8896601420
Cr-Commit-Position: refs/heads/master@{#318858}

Powered by Google App Engine
This is Rietveld 408576698