components/guest_view/browser/guest_view_manager.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_manager.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: add basic postMessage test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/guest_view/web_view_browsertest.cc ('K') | « components/guest_view/browser/guest_view_base.cc ('k') | components/guest_view/browser/guest_view_manager.cc » ('j') | content/browser/browser_plugin/browser_plugin_guest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/guest_view_manager.h

diff --git a/components/guest_view/browser/guest_view_manager.h b/components/guest_view/browser/guest_view_manager.h

index 278c2cbaadc644153554c3960b7589383d0ea5a0..007f8ba97b575b151b7a03c8ea9b890487515627 100644

--- a/components/guest_view/browser/guest_view_manager.h

+++ b/components/guest_view/browser/guest_view_manager.h

@@ -67,6 +67,10 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

int guest_instance_id,

const base::DictionaryValue& attach_params);

+ // Relax GetGuestByInstanceID for now, so we can wildly access a guest by

+ // its guest_instance_id.

+ content::WebContents* GetGuestByInstanceIDHack(int guest_instance_id);

// Removes the association between |element_instance_id| and a guest instance

// ID if one exists.

void DetachGuest(GuestViewBase* guest);