components/guest_view/browser/guest_view_base.cc - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: add basic postMessage test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/guest_view/web_view_browsertest.cc ('K') | « chrome/test/data/extensions/platform_apps/web_view/post_message/test.js ('k') | components/guest_view/browser/guest_view_manager.h » ('j') | content/browser/browser_plugin/browser_plugin_guest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/guest_view_base.cc

diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc

index 201e08108e395fef62f7aa205fbb4cb6907a7c12..f24749e10e46a6de90f3a4c16813a026ce90e361 100644

--- a/components/guest_view/browser/guest_view_base.cc

+++ b/components/guest_view/browser/guest_view_base.cc

@@ -217,8 +217,8 @@ void GuestViewBase::InitWithWebContents(

// Populate the view instance ID if we have it on creation.

create_params.GetInteger(kParameterInstanceId, &view_instance_id_);

- if (CanRunInDetachedState())

- SetUpSizing(create_params);

+ // if (CanRunInDetachedState())

+ // SetUpSizing(create_params);

// Observe guest zoom changes.

auto zoom_controller =

@@ -379,8 +379,8 @@ content::WebContents* GuestViewBase::CreateNewGuestWindow(

}

void GuestViewBase::DidAttach(int guest_proxy_routing_id) {

- DCHECK(guest_proxy_routing_id_ == MSG_ROUTING_NONE ||

- guest_proxy_routing_id == guest_proxy_routing_id_);

+ // DCHECK(guest_proxy_routing_id_ == MSG_ROUTING_NONE ||

+ // guest_proxy_routing_id == guest_proxy_routing_id_);

guest_proxy_routing_id_ = guest_proxy_routing_id;

opener_lifetime_observer_.reset();