content/browser/browser_plugin/browser_plugin_guest.h - Issue 972313002: Make <webview> use out-of-process iframe architecture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 972313002: Make <webview> use out-of-process iframe architecture. (Closed) Base URL: ssh://saopaulo.wat/mnt/dev/shared/src@testoopif2z-better-chrome

Patch Set: add basic postMessage test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/guest_view/web_view_browsertest.cc ('K') | « components/guest_view/browser/guest_view_manager.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/browser/browser_plugin/browser_plugin_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 86278b98694810af4cffc6ec4fa01b6f71f4346d..aa3039fc3f7655ef16c17f89508c45b62ad5af0c 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -77,6 +77,9 @@ struct DropData;

// A BrowserPluginGuest can also create a new unattached guest via

// CreateNewWindow. The newly created guest will live in the same partition,

// which means it can share storage and can script this guest.

+//

+// Note that all IPC sent out from this class will be dropped on the

+// floor b/c we don't have a BrowserPlugin anymore.

Charlie Reis 2015/05/19 07:12:31 This comment needs updating, assuming it only appl

lazyboy 2015/05/21 23:23:46 Done.

class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,

public WebContentsObserver {

public: