Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 9694025: Add support for GL_COMMANDS_ISSUED_CHROMIUM fence like query. (Closed)

Created:
8 years, 9 months ago by greggman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Add support for GL_COMMANDS_ISSUED_CHROMIUM fence like query. I'm not sure this is the right way to do this. I started by adding a few switch/case statements and then realized that there is no guarntee that glGenQueriesXXX exists which means I have to NOT call that for GL_COMMANDS_ISSUED_CHROMIUM queries. I ended up going down the path of a base class and this is where it lead. TEST=unit tests BUG=117768 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126607

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : remove PRESUBMIT.py #

Patch Set 4 : deal with ARB vs EXT diffs #

Patch Set 5 : add cast for std::min #

Unified diffs Side-by-side diffs Delta from patch set Stats (+659 lines, -442 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 4 chunks +5 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 2 chunks +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 8 chunks +43 lines, -42 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 3 chunks +114 lines, -19 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 4 chunks +0 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 1 chunk +4 lines, -92 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 3 chunks +96 lines, -88 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/query_manager.h View 1 2 3 6 chunks +75 lines, -40 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 1 2 3 4 6 chunks +197 lines, -64 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 1 2 3 19 chunks +96 lines, -69 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/khronos/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
greggman
Hey Al, PTAL
8 years, 9 months ago (2012-03-13 01:49:43 UTC) #1
apatrick_chromium
lgtm http://codereview.chromium.org/9694025/diff/1/gpu/command_buffer/service/query_manager.h File gpu/command_buffer/service/query_manager.h (right): http://codereview.chromium.org/9694025/diff/1/gpu/command_buffer/service/query_manager.h#newcode31 gpu/command_buffer/service/query_manager.h:31: explicit Query(QueryManager* manager, GLenum target, explicit is redundant
8 years, 9 months ago (2012-03-13 19:24:15 UTC) #2
nduca
http://codereview.chromium.org/9694025/diff/1/gpu/command_buffer/service/feature_info.cc File gpu/command_buffer/service/feature_info.cc (right): http://codereview.chromium.org/9694025/diff/1/gpu/command_buffer/service/feature_info.cc#newcode121 gpu/command_buffer/service/feature_info.cc:121: AddExtensionString("GL_CHROMIUM_fence"); can we call this something liek GL_CHROMIUM_command_buffer_whatever to ...
8 years, 9 months ago (2012-03-13 19:55:54 UTC) #3
greggman
Anything is good for me. Theoretically though we could have more info How about GL_CHROMIUM_command_buffer_query? ...
8 years, 9 months ago (2012-03-13 20:05:57 UTC) #4
nduca
Thats hot
8 years, 9 months ago (2012-03-13 20:07:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9694025/8001
8 years, 9 months ago (2012-03-14 04:36:50 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 07:27:37 UTC) #7
Change committed as 126607

Powered by Google App Engine
This is Rietveld 408576698