[bindings] Make toFloat inline

[bindings] Make toFloat inline

The patch [1] split toDouble into inline fast path and non-inline slow path.
This CL is a further continuation to make toFloat() inline to take the above advantage.

R=jl@opera.com

[1] https://codereview.chromium.org/939923002

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191175

[vivekg, 2015-03-02 13:33:29]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-03-02 13:33:29]

PTAL, thanks!

[Jens Widell, 2015-03-02 13:40:25]

LGTM

https://codereview.chromium.org/967293002/diff/1/Source/bindings/core/v8/V8Bi...
File Source/bindings/core/v8/V8Binding.h (right):

https://codereview.chromium.org/967293002/diff/1/Source/bindings/core/v8/V8Bi...
Source/bindings/core/v8/V8Binding.h:501: inline float
toFloat(v8::Local<v8::Value> value)
AFAICT, this function is not used. I don't think it's meaningful to have, so
feel free to remove it.

[haraken, 2015-03-02 13:43:33]

LGTM

[Daniel Bratell, 2015-03-02 13:56:56]

Could you expand the commit message a bit? It doesn't say anything about why you
do this change which is always good to have in a commit message when later doing
archeology.

[vivekg, 2015-03-02 14:14:44]

vivekg@chromium.org changed reviewers:
+ haraken@chromium.org

[vivekg, 2015-03-02 14:18:51]

On 2015/03/02 at 13:40:25, jl wrote:
> LGTM
> 
>
https://codereview.chromium.org/967293002/diff/1/Source/bindings/core/v8/V8Bi...
> File Source/bindings/core/v8/V8Binding.h (right):
> 
>
https://codereview.chromium.org/967293002/diff/1/Source/bindings/core/v8/V8Bi...
> Source/bindings/core/v8/V8Binding.h:501: inline float
toFloat(v8::Local<v8::Value> value)
> AFAICT, this function is not used. I don't think it's meaningful to have, so
feel free to remove it.

Thanks, done.

[vivekg, 2015-03-02 14:19:08]

On 2015/03/02 at 13:56:56, bratell wrote:
> Could you expand the commit message a bit? It doesn't say anything about why
you do this change which is always good to have in a commit message when later
doing archeology.

Done, thanks.

[vivekg, 2015-03-02 14:19:18]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2015-03-02 14:19:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jl@opera.com
Link to the patchset: https://codereview.chromium.org/967293002/#ps20001 (title:
"Patch for landing")

[commit-bot: I haz the power, 2015-03-02 14:20:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/967293002/20001

[commit-bot: I haz the power, 2015-03-02 14:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 14:50:30]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)

[vivekg, 2015-03-03 04:01:53]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2015-03-03 04:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jl@opera.com
Link to the patchset: https://codereview.chromium.org/967293002/#ps40001 (title:
"Removed stale code")

[commit-bot: I haz the power, 2015-03-03 04:02:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/967293002/40001

[commit-bot: I haz the power, 2015-03-03 07:18:27]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191175