Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 967293002: [bindings] Make toFloat inline (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Make toFloat inline The patch [1] split toDouble into inline fast path and non-inline slow path. This CL is a further continuation to make toFloat() inline to take the above advantage. R=jl@opera.com [1] https://codereview.chromium.org/939923002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191175

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Patch Set 3 : Removed stale code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M Source/bindings/core/v8/V8Binding.h View 1 2 2 chunks +9 lines, -12 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 2 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8BindingTest.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
vivekg
PTAL, thanks!
5 years, 9 months ago (2015-03-02 13:33:29 UTC) #2
Jens Widell
LGTM https://codereview.chromium.org/967293002/diff/1/Source/bindings/core/v8/V8Binding.h File Source/bindings/core/v8/V8Binding.h (right): https://codereview.chromium.org/967293002/diff/1/Source/bindings/core/v8/V8Binding.h#newcode501 Source/bindings/core/v8/V8Binding.h:501: inline float toFloat(v8::Local<v8::Value> value) AFAICT, this function is ...
5 years, 9 months ago (2015-03-02 13:40:25 UTC) #3
haraken
LGTM
5 years, 9 months ago (2015-03-02 13:43:33 UTC) #4
Daniel Bratell
Could you expand the commit message a bit? It doesn't say anything about why you ...
5 years, 9 months ago (2015-03-02 13:56:56 UTC) #5
vivekg
On 2015/03/02 at 13:40:25, jl wrote: > LGTM > > https://codereview.chromium.org/967293002/diff/1/Source/bindings/core/v8/V8Binding.h > File Source/bindings/core/v8/V8Binding.h (right): ...
5 years, 9 months ago (2015-03-02 14:18:51 UTC) #7
vivekg
On 2015/03/02 at 13:56:56, bratell wrote: > Could you expand the commit message a bit? ...
5 years, 9 months ago (2015-03-02 14:19:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967293002/20001
5 years, 9 months ago (2015-03-02 14:20:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/30109)
5 years, 9 months ago (2015-03-02 14:50:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967293002/40001
5 years, 9 months ago (2015-03-03 04:02:12 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 07:18:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191175

Powered by Google App Engine
This is Rietveld 408576698