Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: Source/bindings/core/v8/V8BindingTest.cpp

Issue 967293002: [bindings] Make toFloat inline (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed stale code Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8BindingTest.cpp
diff --git a/Source/bindings/core/v8/V8BindingTest.cpp b/Source/bindings/core/v8/V8BindingTest.cpp
index d03d723f67b645ac5fb22d9abc96f970a17efa90..775fab7a8aee678e74d427c3e2679ef2c72208bb 100644
--- a/Source/bindings/core/v8/V8BindingTest.cpp
+++ b/Source/bindings/core/v8/V8BindingTest.cpp
@@ -78,7 +78,6 @@ TEST_F(V8BindingTest, toImplArray)
EXPECT_EQ(3U, v8HandleVector.size());
EXPECT_EQ("Vini, vidi, vici.", toUSVString(v8HandleVector[0], exceptionState));
EXPECT_EQ(65535U, toUInt32(v8HandleVector[1]));
- EXPECT_EQ(0.125, toFloat(v8HandleVector[2]));
Vector<ScriptValue> scriptValueVector = toImplArray<ScriptValue>(v8Array, 0, m_scope.isolate(), exceptionState);
EXPECT_EQ(3U, scriptValueVector.size());
@@ -86,7 +85,6 @@ TEST_F(V8BindingTest, toImplArray)
EXPECT_TRUE(scriptValueVector[0].toString(reportOnZela));
EXPECT_EQ("Vini, vidi, vici.", reportOnZela);
EXPECT_EQ(65535U, toUInt32(scriptValueVector[1].v8Value()));
- EXPECT_EQ(0.125, toFloat(scriptValueVector[2].v8Value()));
}
{
v8::Handle<v8::Array> v8StringArray1 = v8::Array::New(m_scope.isolate(), 2);
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698