Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 967213002: Devtools Animations: Represent delay and end-delay on the animation timeline (Closed)

Created:
5 years, 9 months ago by samli
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, Eric Willigers, caseq+blink_chromium.org, shans, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, blink-reviews-animation_chromium.org, darktears, rjwright, yurys+blink_chromium.org, lushnikov+blink_chromium.org, Mike Lawther (Google), pfeldman+blink_chromium.org, Timothy Loh, Steve Block, apavlov+blink_chromium.org, devtools-reviews_chromium.org, dstockwell, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools Animations: Represent delay and end-delay on the animation timeline BUG=447083 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191387 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191408

Patch Set 1 : #

Patch Set 2 : Add test #

Total comments: 3

Patch Set 3 : Fix test #

Patch Set 4 : Round values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -39 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/animation-timeline.html View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/animation-timeline-expected.txt View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/elements/AnimationTimeline.js View 1 2 3 12 chunks +67 lines, -34 lines 0 comments Download
M Source/devtools/front_end/elements/BezierUI.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elements/animationTimeline.css View 2 chunks +6 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/AnimationModel.js View 3 chunks +10 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
samli
PTAL
5 years, 9 months ago (2015-03-02 06:26:30 UTC) #3
pfeldman
Please add a test. I should emulate the animation timeline and dump the generated SVG.
5 years, 9 months ago (2015-03-02 13:06:34 UTC) #4
samli
PTAL. Added a test which creates fake animations and adds them to the timeline and ...
5 years, 9 months ago (2015-03-03 02:59:33 UTC) #5
pfeldman
https://codereview.chromium.org/967213002/diff/40001/LayoutTests/inspector/elements/animation-timeline.html File LayoutTests/inspector/elements/animation-timeline.html (right): https://codereview.chromium.org/967213002/diff/40001/LayoutTests/inspector/elements/animation-timeline.html#newcode17 LayoutTests/inspector/elements/animation-timeline.html:17: var animation = {"id":"9","pausedState":false,"playState":"running","playbackRate":1,"startTime":1013.51700001396,"currentTime":16.6666667209938,"source":{"delay":250,"endDelay":0,"playbackRate":1,"iterationStart":0,"iterations":1,"duration":1000,"direction":"normal","fill":"none","name":"","backendNodeId":1,"easing":"linear","keyframesRule":{"keyframes":[{"offset":"0%","style":{"cssProperties":[{"name":"transform","value":"translateX(0px)"}],"shorthandEntries":[]},"easing":"linear"},{"offset":"100%","style":{"cssProperties":[{"name":"transform","value":"translateX(100px)"}],"shorthandEntries":[]},"easing":"linear"}]}},"type":"WebAnimation"}; Why is this information not ...
5 years, 9 months ago (2015-03-03 12:44:15 UTC) #6
samli
https://codereview.chromium.org/967213002/diff/40001/LayoutTests/inspector/elements/animation-timeline.html File LayoutTests/inspector/elements/animation-timeline.html (right): https://codereview.chromium.org/967213002/diff/40001/LayoutTests/inspector/elements/animation-timeline.html#newcode17 LayoutTests/inspector/elements/animation-timeline.html:17: var animation = {"id":"9","pausedState":false,"playState":"running","playbackRate":1,"startTime":1013.51700001396,"currentTime":16.6666667209938,"source":{"delay":250,"endDelay":0,"playbackRate":1,"iterationStart":0,"iterations":1,"duration":1000,"direction":"normal","fill":"none","name":"","backendNodeId":1,"easing":"linear","keyframesRule":{"keyframes":[{"offset":"0%","style":{"cssProperties":[{"name":"transform","value":"translateX(0px)"}],"shorthandEntries":[]},"easing":"linear"},{"offset":"100%","style":{"cssProperties":[{"name":"transform","value":"translateX(100px)"}],"shorthandEntries":[]},"easing":"linear"}]}},"type":"WebAnimation"}; On 2015/03/03 12:44:15, pfeldman wrote: ...
5 years, 9 months ago (2015-03-03 21:13:32 UTC) #7
pfeldman
https://codereview.chromium.org/967213002/diff/40001/LayoutTests/inspector/elements/animation-timeline.html File LayoutTests/inspector/elements/animation-timeline.html (right): https://codereview.chromium.org/967213002/diff/40001/LayoutTests/inspector/elements/animation-timeline.html#newcode17 LayoutTests/inspector/elements/animation-timeline.html:17: var animation = {"id":"9","pausedState":false,"playState":"running","playbackRate":1,"startTime":1013.51700001396,"currentTime":16.6666667209938,"source":{"delay":250,"endDelay":0,"playbackRate":1,"iterationStart":0,"iterations":1,"duration":1000,"direction":"normal","fill":"none","name":"","backendNodeId":1,"easing":"linear","keyframesRule":{"keyframes":[{"offset":"0%","style":{"cssProperties":[{"name":"transform","value":"translateX(0px)"}],"shorthandEntries":[]},"easing":"linear"},{"offset":"100%","style":{"cssProperties":[{"name":"transform","value":"translateX(100px)"}],"shorthandEntries":[]},"easing":"linear"}]}},"type":"WebAnimation"}; I am sure you can ...
5 years, 9 months ago (2015-03-04 12:54:03 UTC) #8
samli
Figured it out, PTAL
5 years, 9 months ago (2015-03-05 02:00:07 UTC) #9
pfeldman
lgtm
5 years, 9 months ago (2015-03-05 20:14:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967213002/60001
5 years, 9 months ago (2015-03-05 20:31:33 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=191387
5 years, 9 months ago (2015-03-05 21:53:52 UTC) #13
Dirk Pranke
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/980053006/ by dpranke@chromium.org. ...
5 years, 9 months ago (2015-03-06 00:37:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967213002/80001
5 years, 9 months ago (2015-03-06 02:17:05 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 04:14:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191408

Powered by Google App Engine
This is Rietveld 408576698