Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 980053006: Revert of Devtools Animations: Represent delay and end-delay on the animation timeline (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
pfeldman, samli
CC:
blink-reviews, Eric Willigers, caseq+blink_chromium.org, shans, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, blink-reviews-animation_chromium.org, darktears, rjwright, yurys+blink_chromium.org, lushnikov+blink_chromium.org, Mike Lawther (Google), pfeldman+blink_chromium.org, Timothy Loh, Steve Block, apavlov+blink_chromium.org, devtools-reviews_chromium.org, dstockwell, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Devtools Animations: Represent delay and end-delay on the animation timeline (patchset #3 id:60001 of https://codereview.chromium.org/967213002/) Reason for revert: This new layout test appears to fail pretty much everywhere, with minor floating-point rounding errors in the ~12th digit :). Is it possible to write this test in a way that doesn't require so much precision in the output? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Felements%2Fanimation-timeline.html Original issue's description: > Devtools Animations: Represent delay and end-delay on the animation timeline > > BUG=447083 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191387 TBR=pfeldman@chromium.org,samli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447083 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -165 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +1 line, -19 lines 0 comments Download
D LayoutTests/inspector/elements/animation-timeline.html View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/inspector/elements/animation-timeline-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/AnimationTimeline.js View 9 chunks +29 lines, -60 lines 0 comments Download
M Source/devtools/front_end/elements/animationTimeline.css View 2 chunks +1 line, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/AnimationModel.js View 3 chunks +2 lines, -10 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Created Revert of Devtools Animations: Represent delay and end-delay on the animation timeline
5 years, 9 months ago (2015-03-06 00:37:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980053006/1
5 years, 9 months ago (2015-03-06 00:38:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191395
5 years, 9 months ago (2015-03-06 00:38:56 UTC) #3
pfeldman
5 years, 9 months ago (2015-03-06 05:05:39 UTC) #4
Message was sent while issue was closed.
On 2015/03/06 00:38:56, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=191395

I was actually sure it does not pass the try bots. Then I thought it would be a
good stress test for the system if it does :)

Powered by Google App Engine
This is Rietveld 408576698