Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 966393002: ServiceWorkerVersion: remove unused parameter in DispatchInstallEvent (Closed)

Created:
5 years, 9 months ago by kinuko
Modified:
5 years, 9 months ago
Reviewers:
falken, Tom Sepez
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorkerVersion: remove unused parameter in DispatchInstallEvent I believe the param (active_version_id) was a remnant of the ancient spec/impl. BUG=n/a Committed: https://crrev.com/29be3dc620d0a0eab956a596254baa1a5dc657fd Cr-Commit-Position: refs/heads/master@{#319031}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Build fix #

Patch Set 4 : rebase #

Patch Set 5 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -38 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kinuko
One more mechanical cleanup. PTL
5 years, 9 months ago (2015-03-02 08:47:43 UTC) #2
falken
nice lgtm
5 years, 9 months ago (2015-03-03 01:44:34 UTC) #3
kinuko
tsepez@: could you review service_worker_messages.h changes? Thanks!
5 years, 9 months ago (2015-03-03 03:44:30 UTC) #5
Tom Sepez
RS LGTM on deleting parameter.
5 years, 9 months ago (2015-03-03 17:34:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966393002/80001
5 years, 9 months ago (2015-03-04 07:16:37 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-04 08:29:57 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 08:30:42 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/29be3dc620d0a0eab956a596254baa1a5dc657fd
Cr-Commit-Position: refs/heads/master@{#319031}

Powered by Google App Engine
This is Rietveld 408576698