content/browser/service_worker/service_worker_version_unittest.cc - Issue 966393002: ServiceWorkerVersion: remove unused parameter in DispatchInstallEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 966393002: ServiceWorkerVersion: remove unused parameter in DispatchInstallEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version_unittest.cc

diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc

index bdcea4770096a151e305075a8378e9e3eb04d0dd..2b3739db96f90fa58a1d709367d61b2450d23d1e 100644

--- a/content/browser/service_worker/service_worker_version_unittest.cc

+++ b/content/browser/service_worker/service_worker_version_unittest.cc

@@ -256,7 +256,7 @@ TEST_F(ServiceWorkerVersionTest, DispatchEventToStoppedWorker) {

// Dispatch an event without starting the worker.

ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;

version_->SetStatus(ServiceWorkerVersion::INSTALLING);

- version_->DispatchInstallEvent(-1, CreateReceiverOnCurrentThread(&status));

+ version_->DispatchInstallEvent(CreateReceiverOnCurrentThread(&status));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(SERVICE_WORKER_OK, status);

@@ -267,8 +267,7 @@ TEST_F(ServiceWorkerVersionTest, DispatchEventToStoppedWorker) {

status = SERVICE_WORKER_ERROR_FAILED;

ServiceWorkerStatusCode stop_status = SERVICE_WORKER_ERROR_FAILED;

version_->StopWorker(CreateReceiverOnCurrentThread(&stop_status));

- version_->DispatchInstallEvent(

- -1, CreateReceiverOnCurrentThread(&status));

+ version_->DispatchInstallEvent(CreateReceiverOnCurrentThread(&status));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(SERVICE_WORKER_OK, stop_status);

@@ -308,7 +307,7 @@ TEST_F(ServiceWorkerVersionTest, InstallAndWaitCompletion) {

// Dispatch an install event.

ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;

- version_->DispatchInstallEvent(-1, CreateReceiverOnCurrentThread(&status));

+ version_->DispatchInstallEvent(CreateReceiverOnCurrentThread(&status));

// Wait for the completion.

bool status_change_called = false;