content/browser/service_worker/service_worker_job_unittest.cc - Issue 966393002: ServiceWorkerVersion: remove unused parameter in DispatchInstallEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 966393002: ServiceWorkerVersion: remove unused parameter in DispatchInstallEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_handle_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc

index ef9c99a6d05e072e363133f4747e5760d9102b2e..5e54e07e3b2743e0a09e928a024d86656ff053a7 100644

--- a/content/browser/service_worker/service_worker_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_job_unittest.cc

@@ -1262,8 +1262,7 @@ class EventCallbackHelper : public EmbeddedWorkerTestHelper {

activate_event_result_(blink::WebServiceWorkerEventResultCompleted) {}

void OnInstallEvent(int embedded_worker_id,

- int request_id,

- int active_version_id) override {

+ int request_id) override {

if (!install_callback_.is_null())

install_callback_.Run();

SimulateSend(