Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 966393002: ServiceWorkerVersion: remove unused parameter in DispatchInstallEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 220c67a21ab2b792d7670ede2567755a1f563723..5c53d23f345cb41c8c9f67fb29424abfd0af2784 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -175,15 +175,12 @@ class CONTENT_EXPORT ServiceWorkerVersion
// Sends install event to the associated embedded worker and asynchronously
// calls |callback| when it errors out or it gets a response from the worker
// to notify install completion.
- // |active_version_id| must be a valid positive ID
- // if there's an activated (previous) version running.
//
// This must be called when the status() is NEW. Calling this changes
// the version's status to INSTALLING.
// Upon completion, the version's status will be changed to INSTALLED
// on success, or back to NEW on failure.
- void DispatchInstallEvent(int active_version_id,
- const StatusCallback& callback);
+ void DispatchInstallEvent(const StatusCallback& callback);
// Sends activate event to the associated embedded worker and asynchronously
// calls |callback| when it errors out or it gets a response from the worker
@@ -341,8 +338,7 @@ class CONTENT_EXPORT ServiceWorkerVersion
void OnStartMessageSent(ServiceWorkerStatusCode status);
- void DispatchInstallEventAfterStartWorker(int active_version_id,
- const StatusCallback& callback);
+ void DispatchInstallEventAfterStartWorker(const StatusCallback& callback);
void DispatchActivateEventAfterStartWorker(const StatusCallback& callback);
void DispatchMessageEventInternal(

Powered by Google App Engine
This is Rietveld 408576698