Remove deprecated overload of didNavigateMainFrame

Remove deprecated overload of didNavigateMainFrame

The WebContentsObserver.didNavigateMainFrame overload without an
http status code is deprecated. Stop using it, also fixing an issue
where the wrong overload was called by WebContentsObserverProxy.

BUG=440134
TBR=dtrainor@chromium.org

Committed: https://crrev.com/746f23b61b7b1081af670b65da09975120d64f27
Cr-Commit-Position: refs/heads/master@{#319189}

[jdduke (slow), 2015-03-05 00:07:30]

jdduke@chromium.org changed reviewers:
+ boliu@chromium.org, dtrainor@chromium.org

[jdduke (slow), 2015-03-05 00:07:31]

+dtrainor for content/
+boliu for android_webview/

[jdduke (slow), 2015-03-05 00:08:13]

+cc: yusufo, FYI.

[boliu, 2015-03-05 00:17:52]

aw lgtm

https://codereview.chromium.org/962103003/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java
(right):

https://codereview.chromium.org/962103003/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java:90:
int httpStatusCode = 0;
nit: 200 maybe?

https://codereview.chromium.org/962103003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
(right):

https://codereview.chromium.org/962103003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java:221:
for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {
This seems like an unrelated change? Separate CL?

[jdduke (slow), 2015-03-05 00:26:40]

https://codereview.chromium.org/962103003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
(right):

https://codereview.chromium.org/962103003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java:221:
for (mObserversIterator.rewind(); mObserversIterator.hasNext();) {
On 2015/03/05 00:17:52, boliu wrote:
> This seems like an unrelated change? Separate CL?

Oops, yeah this was just a bad save (the joys of editing over sshd...). None of
this belongs here, I'll clean it up.

[jdduke (slow), 2015-03-05 00:28:02]

https://codereview.chromium.org/962103003/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java
(right):

https://codereview.chromium.org/962103003/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java:90:
int httpStatusCode = 0;
On 2015/03/05 00:17:52, boliu wrote:
> nit: 200 maybe?

Done.

[jdduke (slow), 2015-03-05 00:28:51]

On 2015/03/05 00:26:40, jdduke wrote:
> Oops, yeah this was just a bad save (the joys of editing over sshd...). None
of
> this belongs here, I'll clean it up.

ssfhs that is, lol...

[jdduke (slow), 2015-03-05 01:10:30]

TBR'ing as the fix is trivial and resolves some pretty broken downstream
functionality.

[jdduke (slow), 2015-03-05 01:10:45]

The CQ bit was checked by jdduke@chromium.org

[jdduke (slow), 2015-03-05 01:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/962103003/#ps20001 (title:
"Code review")

[commit-bot: I haz the power, 2015-03-05 01:11:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/962103003/20001

[David Trainor- moved to gerrit, 2015-03-05 01:13:05]

lgtm

[commit-bot: I haz the power, 2015-03-05 01:21:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-05 01:22:38]

Patchset 2 (id:??) landed as
https://crrev.com/746f23b61b7b1081af670b65da09975120d64f27
Cr-Commit-Position: refs/heads/master@{#319189}