Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java

Issue 962103003: Remove deprecated overload of didNavigateMainFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
diff --git a/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java b/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
index 3d239db8763431a46d9bdda577177479894ae088..39185a3259e78e7faf9b0c2bb5e9167ab34402f4 100644
--- a/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
+++ b/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
@@ -52,18 +52,6 @@ public abstract class WebContentsObserver {
/**
* Called when the main frame of the page has committed.
- * TODO(pedrosimonetti): Remove this method once downstream changes are landed.
- * @param url The validated url for the page.
- * @param baseUrl The validated base url for the page.
- * @param isNavigationToDifferentPage Whether the main frame navigated to a different page.
- * @param isFragmentNavigation Whether the main frame navigation did not cause changes to the
- * document (for example scrolling to a named anchor or PopState).
- */
- public void didNavigateMainFrame(String url, String baseUrl,
- boolean isNavigationToDifferentPage, boolean isFragmentNavigation) {}
-
- /**
- * Called when the main frame of the page has committed.
* @param url The validated url for the page.
* @param baseUrl The validated base url for the page.
* @param isNavigationToDifferentPage Whether the main frame navigated to a different page.
@@ -72,9 +60,7 @@ public abstract class WebContentsObserver {
* @param statusCode The HTTP status code of the navigation.
*/
public void didNavigateMainFrame(String url, String baseUrl,
- boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) {
- didNavigateMainFrame(url, baseUrl, isNavigationToDifferentPage, isFragmentNavigation);
- }
+ boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) {}
/**
* Called when the page had painted something non-empty.
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698