android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java - Issue 962103003: Remove deprecated overload of didNavigateMainFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

Issue 962103003: Remove deprecated overload of didNavigateMainFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

index 856d9ceab977deca95139dc14a25cd6b21b9ee86..926d77fb1d486143e717a92aea20e8cb14cf76ad 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java

@@ -60,7 +60,7 @@ public class AwWebContentsObserver extends WebContentsObserver {

@Override

public void didNavigateMainFrame(String url, String baseUrl,

- boolean isNavigationToDifferentPage, boolean isFragmentNavigation) {

+ boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) {

// This is here to emulate the Classic WebView firing onPageFinished for main frame

// navigations where only the hash fragment changes.

if (isFragmentNavigation) {

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java » ('j') | no next file with comments »