android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java - Issue 962103003: Remove deprecated overload of didNavigateMainFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java

Issue 962103003: Remove deprecated overload of didNavigateMainFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java

index 58378f317aa1462df5f23166055f434b1b3fe153..109e29c96b3302c2dc4695a6ad68a3aa44bb49d4 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java

@@ -87,15 +87,16 @@ public class AwWebContentsObserverTest extends AwTestBase {

String baseUrl = null;

boolean navigationToDifferentPage = true;

boolean fragmentNavigation = true;

+ int httpStatusCode = 200;

callCount = mContentsClient.getOnPageFinishedHelper().getCallCount();

mWebContentsObserver.didNavigateMainFrame(EXAMPLE_URL, baseUrl,

- !navigationToDifferentPage, fragmentNavigation);

+ !navigationToDifferentPage, fragmentNavigation, httpStatusCode);

assertEquals("onPageFinished should be called for main frame fragment navigations.",

callCount + 1, mContentsClient.getOnPageFinishedHelper().getCallCount());

callCount = mContentsClient.getOnPageFinishedHelper().getCallCount();

mWebContentsObserver.didNavigateMainFrame(EXAMPLE_URL, baseUrl,

- !navigationToDifferentPage, !fragmentNavigation);

+ !navigationToDifferentPage, !fragmentNavigation, httpStatusCode);

assertEquals("onPageFinished should be called only for main frame fragment navigations.",

callCount, mContentsClient.getOnPageFinishedHelper().getCallCount());

}