Typecheck constructor initializers properly

Typecheck constructor initializers properly

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/4ba5eb736224f6e34abe230c5319100dac1dd21e

[vsm, 2015-02-26 21:27:02]

vsm@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2015-02-26 22:00:16]

Couple comments, but basically lgtm.

https://codereview.chromium.org/959003003/diff/1/lib/src/checker/checker.dart
File lib/src/checker/checker.dart (right):

https://codereview.chromium.org/959003003/diff/1/lib/src/checker/checker.dart...
lib/src/checker/checker.dart:384: }
A little surprising that this isn't in a separate
visitConstructorFieldInitialization method, but ok.

https://codereview.chromium.org/959003003/diff/1/test/checker/checker_test.dart
File test/checker/checker_test.dart (right):

https://codereview.chromium.org/959003003/diff/1/test/checker/checker_test.da...
test/checker/checker_test.dart:147: }
I think you can say something like:

A.c3(num this.x, int this.y)

might be worth testing it, making sure we're doing the right thing.

[vsm, 2015-02-26 23:55:48]

PTAL

Added fix for the test you suggested along with constructor invocation checking.

https://codereview.chromium.org/959003003/diff/1/lib/src/checker/checker.dart
File lib/src/checker/checker.dart (right):

https://codereview.chromium.org/959003003/diff/1/lib/src/checker/checker.dart...
lib/src/checker/checker.dart:384: }
On 2015/02/26 22:00:16, leafp wrote:
> A little surprising that this isn't in a separate
> visitConstructorFieldInitialization method, but ok.

Done.

https://codereview.chromium.org/959003003/diff/1/test/checker/checker_test.dart
File test/checker/checker_test.dart (right):

https://codereview.chromium.org/959003003/diff/1/test/checker/checker_test.da...
test/checker/checker_test.dart:147: }
On 2015/02/26 22:00:16, leafp wrote:
> I think you can say something like:
> 
> A.c3(num this.x, int this.y)
> 
> might be worth testing it, making sure we're doing the right thing.

Added - along with code to fix.  :-)

[Leaf, 2015-02-27 00:13:05]

lgtm

[vsm, 2015-02-27 00:19:36]

Committed patchset #3 (id:40001) manually as
4ba5eb736224f6e34abe230c5319100dac1dd21e (presubmit successful).