Typecheck constructor initializers properly

lib/src/checker/checker.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library ddc.src.checker.checker;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/scanner.dart' show Token, TokenType;
@@ skipping 355 matching lines @@
     }
     node.visitChildren(this);
   }
 
   /// Check constructor declaration to ensure correct super call placement.
   @override
   visitConstructorDeclaration(ConstructorDeclaration node) {
     node.visitChildren(this);
 
     final init = node.initializers;
-    for (int i = 0, last = init.length - 1; i < last; i++) {
+    for (int i = 0, last = init.length - 1; i <= last; i++) {
       final node = init[i];
-      if (node is SuperConstructorInvocation) {
+      if (i != last && node is SuperConstructorInvocation) {
         _recordMessage(new InvalidSuperInvocation(node));
+      } else if (node is ConstructorFieldInitializer) {
+        var field = node.fieldName;
+        DartType staticType = _rules.elementType(field.staticElement);
+        node.expression = checkAssignment(node.expression, staticType);
       }

[Leaf, 2015/02/26 22:00:16]

A little surprising that this isn't in a separate
visitConstructorFieldInitialization method, but ok.

[vsm, 2015/02/26 23:55:47]

Done.

     }
   }
 
   // Check invocations
   bool checkArgumentList(ArgumentList node, FunctionType type) {
     NodeList<Expression> list = node.arguments;
     int len = list.length;
     for (int i = 0; i < len; ++i) {
       Expression arg = list[i];
       ParameterElement element = node.getStaticParameterElementFor(arg);
@@ skipping 279 matching lines @@
   void _recordDynamicInvoke(AstNode node) {
     _reporter.log(new DynamicInvoke(_rules, node));
   }
 
   void _recordMessage(StaticInfo info) {
     if (info == null) return;
     if (info.level >= logger.Level.SEVERE) _failure = true;
     _reporter.log(info);
   }
 }