Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: lib/src/checker/checker.dart

Issue 959003003: Typecheck constructor initializers properly (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/checker/dart_sdk.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/checker/checker.dart
diff --git a/lib/src/checker/checker.dart b/lib/src/checker/checker.dart
index f11aef694ff1ac139d46db6066191c78d3d8860f..147b889498d3fcce9105b662a86354f2fad3f99d 100644
--- a/lib/src/checker/checker.dart
+++ b/lib/src/checker/checker.dart
@@ -381,6 +381,14 @@ class CodeChecker extends RecursiveAstVisitor {
}
}
+ @override
+ visitConstructorFieldInitializer(ConstructorFieldInitializer node) {
+ var field = node.fieldName;
+ DartType staticType = _rules.elementType(field.staticElement);
+ node.expression = checkAssignment(node.expression, staticType);
+ node.visitChildren(this);
+ }
+
// Check invocations
bool checkArgumentList(ArgumentList node, FunctionType type) {
NodeList<Expression> list = node.arguments;
@@ -534,6 +542,37 @@ class CodeChecker extends RecursiveAstVisitor {
node.visitChildren(this);
}
+ visitFieldFormalParameter(FieldFormalParameter node) {
+ var element = node.element;
+ var typeName = node.type;
+ if (typeName != null) {
+ var type = _rules.elementType(element);
+ var fieldElement =
+ node.identifier.staticElement as FieldFormalParameterElement;
+ var fieldType = _rules.elementType(fieldElement.field);
+ if (!_rules.isSubTypeOf(type, fieldType)) {
+ var staticInfo =
+ new InvalidParameterDeclaration(_rules, node, fieldType);
+ _recordMessage(staticInfo);
+ }
+ }
+ node.visitChildren(this);
+ }
+
+ @override
+ visitInstanceCreationExpression(InstanceCreationExpression node) {
+ var arguments = node.argumentList;
+ var element = node.staticElement;
+ if (element != null) {
+ var type = _rules.elementType(node.staticElement);
+ checkArgumentList(arguments, type);
+ } else {
+ _recordMessage(new MissingTypeError(node));
+ }
+ node.visitChildren(this);
+ }
+
+ @override
visitVariableDeclarationList(VariableDeclarationList node) {
TypeName type = node.type;
if (type == null) {
« no previous file with comments | « no previous file | lib/src/checker/dart_sdk.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698