Typecheck constructor initializers properly

test/checker/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// General type checking tests
 library ddc.test.checker_test;
 
 import 'package:unittest/compact_vm_config.dart';
 import 'package:unittest/unittest.dart';
 
@@ skipping 112 matching lines @@
           // check at construction.
           T x;
 
           // TODO(vsm): Should this be a different type of DownCast?
           T foo() => /*warning:DownCastLiteral*/null;
         }
       '''
     });
   });
 
+  test('Constructors', () {
+    testChecker({
+      '/main.dart': '''
+      const num z = 25;
+
+      class A {
+        int x;
+        String y;
+
+        A(this.x) : this.y = /*severe:StaticTypeError*/42;
+
+        A.c1(p): this.x = /*info:DownCast*/z, this.y = /*info:DownCast*/p;
+
+        A.c2(this.x, this.y);
+      }

[Leaf, 2015/02/26 22:00:16]

I think you can say something like:

A.c3(num this.x, int this.y)

might be worth testing it, making sure we're doing the right thing.

[vsm, 2015/02/26 23:55:47]

Added - along with code to fix.  :-)

+
+      class B extends A {
+        B() : super(/*severe:StaticTypeError*/"hello");
+
+        B.c2(int x, String y) : super.c2(/*severe:StaticTypeError*/y, 
+                                         /*severe:StaticTypeError*/x);
+      }
+
+      void main() {
+         var a = new A.c2(z, z);
+      }
+   '''
+    });
+  });
+
   test('Unbound variable', () {
     testChecker({
       '/main.dart': '''
       void main() {
          dynamic y = /*pass should be severe:StaticTypeError*/unboundVariable;
       }
    '''
     });
   });
 
@@ skipping 2460 matching lines @@
         '/main.dart': '''
             class A {}
             class T1 implements A {
                 /*severe:InferableOverride*/toString() {}
             }
          '''
       }, inferFromOverrides: false);
     });
   });
 }