Migrate most DataReductionProxyParams methods to be private.

Migrate most DataReductionProxyParams methods to be private.

This further shifts Data Reduction Proxy code from using Params to using
Config.

BUG=452773
Committed: https://crrev.com/6ccace4dafa0b74c6933d14caea548a2cbfd3244
Cr-Commit-Position: refs/heads/master@{#318596}

[jeremyim, 2015-02-25 21:00:16]

jeremyim@chromium.org changed reviewers:
+ bengr@chromium.org

[jeremyim, 2015-02-25 21:00:17]

PTAL. =)

[bengr, 2015-02-26 00:53:26]

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
(right):

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h:148:
// Returns true if the proxy was using the SSL origin.
Can we change the name of this method and the comment? Maybe a better name is
ProxyUsesSSL? And for a comment, how about: Returns true if SSL will be used to
connect to the provided proxy server.

Finally, why do we even need this method? Can't we just use ProxyServer, which
contains this information internally?

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc
(right):

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc:514:
testing::NotNull()))
indentation

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
(right):

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:150:
friend class DataReductionProxyConfig;
Is this temporary? Can you add a TODO?

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:151:
friend class DataReductionProxyParamsTest;
It would be better if the tests could access params through config.

[jeremyim, 2015-02-26 07:18:54]

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
(right):

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h:148:
// Returns true if the proxy was using the SSL origin.
On 2015/02/26 00:53:26, bengr wrote:
> Can we change the name of this method and the comment? Maybe a better name is
> ProxyUsesSSL? And for a comment, how about: Returns true if SSL will be used
to
> connect to the provided proxy server.
> 
> Finally, why do we even need this method? Can't we just use ProxyServer, which
> contains this information internally?

Done.

The name (and logic) are definitely confusing. AFAICT, the logic (lifted from
request_options) is to check whether this is using the HTTP tunnel for HTTPS
requests.

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc
(right):

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats_unittest.cc:514:
testing::NotNull()))
On 2015/02/26 00:53:26, bengr wrote:
> indentation

Done.

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
(right):

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:150:
friend class DataReductionProxyConfig;
On 2015/02/26 00:53:26, bengr wrote:
> Is this temporary? Can you add a TODO?

Done.

https://codereview.chromium.org/958683002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:151:
friend class DataReductionProxyParamsTest;
On 2015/02/26 00:53:26, bengr wrote:
> It would be better if the tests could access params through config.

Well.. ParamsTest shouldn't really access through config, since we want to test
Params without the indirection.

[jeremyim, 2015-02-26 16:47:26]

Patchset #3 (id:40001) has been deleted

[bengr, 2015-02-27 23:59:08]

lgtm

[jeremyim, 2015-02-28 00:38:12]

The CQ bit was checked by jeremyim@chromium.org

[commit-bot: I haz the power, 2015-02-28 00:39:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958683002/60001

[commit-bot: I haz the power, 2015-02-28 01:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-28 01:51:56]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[jeremyim, 2015-02-28 03:09:12]

The CQ bit was checked by jeremyim@chromium.org

[jeremyim, 2015-02-28 03:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/958683002/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2015-02-28 03:10:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958683002/80001

[commit-bot: I haz the power, 2015-02-28 04:47:29]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-02-28 04:48:39]

Patchset 4 (id:??) landed as
https://crrev.com/6ccace4dafa0b74c6933d14caea548a2cbfd3244
Cr-Commit-Position: refs/heads/master@{#318596}