components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc - Issue 958683002: Migrate most DataReductionProxyParams methods to be private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

Issue 958683002: Migrate most DataReductionProxyParams methods to be private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

index c8869ea3bc2bdb8643aca192d676f5f0d80ad41f..fce83fbe3402a3c22d5acfbc657d483fd9819a6b 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc

@@ -10,7 +10,6 @@

#include "base/test/test_simple_task_runner.h"

#include "base/values.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.h"

-#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"

#include "net/base/capturing_net_log.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -186,13 +185,10 @@ TEST_F(DataReductionProxyConfiguratorTest, TestFallbackRestrictedQuic) {

}

TEST_F(DataReductionProxyConfiguratorTest, TestDisable) {

- data_reduction_proxy::DataReductionProxyParams params(

- data_reduction_proxy::DataReductionProxyParams::

- kAllowAllProxyConfigurations);

config_->Enable(false,

false,

- params.origin().ToURI(),

- params.fallback_origin().ToURI(),

+ "https://www.foo.com:443/",

+ "http://www.bar.com:80/",

"");

config_->Disable();

CheckProxyConfig(net::ProxyConfig::ProxyRules::TYPE_NO_RULES, "", "", "");