components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc - Issue 958683002: Migrate most DataReductionProxyParams methods to be private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

Issue 958683002: Migrate most DataReductionProxyParams methods to be private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

index 24140c9e29a3947e35ba784dff253adf1dd14aba..053394b69698d2e5f5980ac4f206a6da5e987916 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

@@ -677,11 +677,11 @@ TEST_F(ChromeNetworkDailyDataSavingMetricsTest,

.WithParamsFlags(DataReductionProxyParams::kAllowed)

.WithParamsDefinitions(TestDataReductionProxyParams::HAS_ORIGIN)

.Build();

- TestDataReductionProxyParams* params = test_context->config()->test_params();

+ TestDataReductionProxyConfig* config = test_context->config();

net::ProxyConfig data_reduction_proxy_config;

data_reduction_proxy_config.proxy_rules().ParseFromString(

- "http=" + params->origin().host_port_pair().ToString() + ",direct://");

+ "http=" + config->Origin().host_port_pair().ToString() + ",direct://");

data_reduction_proxy_config.proxy_rules().bypass_rules.ParseFromString(

"localbypass.com");

@@ -695,7 +695,7 @@ TEST_F(ChromeNetworkDailyDataSavingMetricsTest,

};

const TestCase test_cases[] = {

{ GURL("http://foo.com"),

- params->origin(),

+ config->Origin(),

base::TimeDelta(),

net::LOAD_NORMAL,

"HTTP/1.1 200 OK\r\nVia: 1.1 Chrome-Compression-Proxy\r\n\r\n",