components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc - Issue 958683002: Migrate most DataReductionProxyParams methods to be private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

Issue 958683002: Migrate most DataReductionProxyParams methods to be private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

index 200852e33f1b96237997d7a51151d33d56c96fa4..985dfa5e18d901fdcefe16fccd58ba193b30209b 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

@@ -281,9 +281,8 @@ void DataReductionProxyRequestOptions::MaybeAddRequestHeaderImpl(

return;

if (data_reduction_proxy_config_ &&

data_reduction_proxy_config_->IsDataReductionProxy(proxy_server, NULL) &&

- ((data_reduction_proxy_config_->params()->ssl_origin().is_valid() &&

- data_reduction_proxy_config_->params()->ssl_origin().host_port_pair()

- .Equals(proxy_server)) == expect_ssl)) {

+ data_reduction_proxy_config_->UsingHTTPTunnel(proxy_server) ==

+ expect_ssl) {

SetHeader(request_headers);

}