Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 956613002: Reland "Cut down /crypto and switch what is left of it to boringssl". (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Reland "Cut down /crypto and switch what is left of it to boringssl". This removes almost all of the /crypto code, leaving around: - openssl_util - random - secure_hash - sha2 which are used by Mojo. This also switches the impl of secure_hash to secure_hash_openssl backed by openssl (in third_party/boring_ssl), as the default one in secure_hash_default is backed by NSS in /net/third_party/nss (and /net is going away). BUG=456130 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/87fdb13fe8e5dcc63b803324d163ed76c746b240

Patch Set 1 : what was originally landed #

Patch Set 2 : Fix for running (what's left of) crypto_unittests on Android. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19041 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/BUILD.gn View 1 2 chunks +6 lines, -264 lines 0 comments Download
D crypto/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D crypto/apple_keychain.h View 1 chunk +0 lines, -108 lines 0 comments Download
D crypto/apple_keychain_ios.mm View 1 chunk +0 lines, -196 lines 0 comments Download
D crypto/apple_keychain_mac.mm View 1 chunk +0 lines, -144 lines 0 comments Download
D crypto/capi_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
D crypto/capi_util.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D crypto/crypto.gyp View 1 chunk +0 lines, -318 lines 0 comments Download
D crypto/crypto.gypi View 1 chunk +0 lines, -105 lines 0 comments Download
D crypto/crypto_nacl.gyp View 1 chunk +0 lines, -47 lines 0 comments Download
D crypto/cssm_init.h View 1 chunk +0 lines, -60 lines 0 comments Download
D crypto/cssm_init.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D crypto/curve25519.h View 1 chunk +0 lines, -48 lines 0 comments Download
D crypto/curve25519.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D crypto/curve25519-donna.c View 1 chunk +0 lines, -592 lines 0 comments Download
D crypto/curve25519_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D crypto/ec_private_key.h View 1 chunk +0 lines, -157 lines 0 comments Download
D crypto/ec_private_key_nss.cc View 1 chunk +0 lines, -405 lines 0 comments Download
D crypto/ec_private_key_openssl.cc View 1 chunk +0 lines, -231 lines 0 comments Download
D crypto/ec_private_key_unittest.cc View 1 chunk +0 lines, -296 lines 0 comments Download
D crypto/ec_signature_creator.h View 1 chunk +0 lines, -66 lines 0 comments Download
D crypto/ec_signature_creator.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D crypto/ec_signature_creator_impl.h View 1 chunk +0 lines, -34 lines 0 comments Download
D crypto/ec_signature_creator_nss.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D crypto/ec_signature_creator_openssl.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D crypto/ec_signature_creator_unittest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D crypto/encryptor.h View 1 chunk +0 lines, -138 lines 0 comments Download
D crypto/encryptor.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D crypto/encryptor_nss.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D crypto/encryptor_openssl.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D crypto/encryptor_unittest.cc View 1 chunk +0 lines, -531 lines 0 comments Download
D crypto/ghash.h View 1 chunk +0 lines, -86 lines 0 comments Download
D crypto/ghash.cc View 1 chunk +0 lines, -259 lines 0 comments Download
D crypto/ghash_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D crypto/hkdf.h View 1 chunk +0 lines, -71 lines 0 comments Download
D crypto/hkdf.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D crypto/hkdf_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D crypto/hmac.h View 1 chunk +0 lines, -93 lines 0 comments Download
D crypto/hmac.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D crypto/hmac_nss.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D crypto/hmac_openssl.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D crypto/hmac_unittest.cc View 1 chunk +0 lines, -295 lines 0 comments Download
D crypto/hmac_win.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D crypto/mac_security_services_lock.h View 1 chunk +0 lines, -25 lines 0 comments Download
D crypto/mac_security_services_lock.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D crypto/mock_apple_keychain.h View 1 chunk +0 lines, -250 lines 0 comments Download
D crypto/mock_apple_keychain.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D crypto/mock_apple_keychain_ios.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D crypto/mock_apple_keychain_mac.cc View 1 chunk +0 lines, -509 lines 0 comments Download
D crypto/nss_crypto_module_delegate.h View 1 chunk +0 lines, -53 lines 0 comments Download
D crypto/nss_util.h View 1 chunk +0 lines, -155 lines 0 comments Download
D crypto/nss_util.cc View 1 chunk +0 lines, -1105 lines 0 comments Download
D crypto/nss_util_internal.h View 1 chunk +0 lines, -113 lines 0 comments Download
D crypto/nss_util_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D crypto/openssl_bio_string.h View 1 chunk +0 lines, -29 lines 0 comments Download
D crypto/openssl_bio_string.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D crypto/openssl_bio_string_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D crypto/p224.h View 1 chunk +0 lines, -60 lines 0 comments Download
D crypto/p224.cc View 1 chunk +0 lines, -758 lines 0 comments Download
D crypto/p224_spake.h View 1 chunk +0 lines, -126 lines 0 comments Download
D crypto/p224_spake.cc View 1 chunk +0 lines, -268 lines 0 comments Download
D crypto/p224_spake_unittest.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D crypto/p224_unittest.cc View 1 chunk +0 lines, -824 lines 0 comments Download
D crypto/rsa_private_key.h View 1 chunk +0 lines, -293 lines 0 comments Download
D crypto/rsa_private_key.cc View 1 chunk +0 lines, -384 lines 0 comments Download
D crypto/rsa_private_key_nss.cc View 1 chunk +0 lines, -332 lines 0 comments Download
D crypto/rsa_private_key_nss_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D crypto/rsa_private_key_openssl.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D crypto/rsa_private_key_unittest.cc View 1 chunk +0 lines, -473 lines 0 comments Download
D crypto/scoped_capi_types.h View 1 chunk +0 lines, -121 lines 0 comments Download
D crypto/scoped_nss_types.h View 1 chunk +0 lines, -61 lines 0 comments Download
D crypto/scoped_test_nss_chromeos_user.h View 1 chunk +0 lines, -43 lines 0 comments Download
D crypto/scoped_test_nss_chromeos_user.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D crypto/scoped_test_nss_db.h View 1 chunk +0 lines, -35 lines 0 comments Download
D crypto/scoped_test_nss_db.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D crypto/scoped_test_system_nss_key_slot.h View 1 chunk +0 lines, -43 lines 0 comments Download
D crypto/scoped_test_system_nss_key_slot.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D crypto/secure_hash_default.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D crypto/secure_util.h View 1 chunk +0 lines, -29 lines 0 comments Download
D crypto/secure_util.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D crypto/signature_creator.h View 1 chunk +0 lines, -73 lines 0 comments Download
D crypto/signature_creator_nss.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D crypto/signature_creator_openssl.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D crypto/signature_creator_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D crypto/signature_verifier.h View 1 chunk +0 lines, -145 lines 0 comments Download
D crypto/signature_verifier_nss.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D crypto/signature_verifier_openssl.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D crypto/signature_verifier_unittest.cc View 1 chunk +0 lines, -1167 lines 0 comments Download
D crypto/symmetric_key.h View 1 chunk +0 lines, -101 lines 0 comments Download
D crypto/symmetric_key_nss.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D crypto/symmetric_key_openssl.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D crypto/symmetric_key_unittest.cc View 1 chunk +0 lines, -225 lines 0 comments Download
D crypto/symmetric_key_win.cc View 1 chunk +0 lines, -536 lines 0 comments Download
D crypto/third_party/nss/LICENSE View 1 chunk +0 lines, -35 lines 0 comments Download
D crypto/third_party/nss/README.chromium View 1 chunk +0 lines, -18 lines 0 comments Download
D crypto/third_party/nss/chromium-blapi.h View 1 chunk +0 lines, -101 lines 0 comments Download
D crypto/third_party/nss/chromium-blapit.h View 1 chunk +0 lines, -91 lines 0 comments Download
D crypto/third_party/nss/chromium-nss.h View 1 chunk +0 lines, -79 lines 0 comments Download
D crypto/third_party/nss/chromium-prtypes.h View 1 chunk +0 lines, -77 lines 0 comments Download
D crypto/third_party/nss/chromium-sha256.h View 1 chunk +0 lines, -51 lines 0 comments Download
D crypto/third_party/nss/pk11akey.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D crypto/third_party/nss/rsawrapr.c View 1 chunk +0 lines, -160 lines 0 comments Download
D crypto/third_party/nss/secsign.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D crypto/third_party/nss/sha512.cc View 1 chunk +0 lines, -1391 lines 0 comments Download
D crypto/wincrypt_shim.h View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Adam, James, Please refer to the email thread on mojo-dev ("Dynamic loading of the ...
5 years, 10 months ago (2015-02-24 17:00:12 UTC) #2
abarth-chromium
rslgtm
5 years, 10 months ago (2015-02-24 17:10:20 UTC) #3
abarth-chromium
rs lgtm
5 years, 10 months ago (2015-02-24 17:10:26 UTC) #4
ppi
5 years, 10 months ago (2015-02-26 14:39:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
87fdb13fe8e5dcc63b803324d163ed76c746b240 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698