Issue 954123002: Remove wm::SHADOW_TYPE_RECTANGULAR_ALWAYS_ACTIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954123002: Remove wm::SHADOW_TYPE_RECTANGULAR_ALWAYS_ACTIVE. (Closed)

Created:
5 years, 10 months ago by jackhou1

Modified:
5 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove wm::SHADOW_TYPE_RECTANGULAR_ALWAYS_ACTIVE. This was added for athena here: https://codereview.chromium.org/455543004 Since athena has been deleted, this is no longer used. BUG=440818 Committed: https://crrev.com/cbc5df777caae32d4c48a5e22f389f4642994a0d Cr-Commit-Position: refs/heads/master@{#318110}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -65 lines)			Patch
M	ui/wm/core/shadow_controller.cc	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	ui/wm/core/shadow_controller_unittest.cc	View	1 chunk	+0 lines, -54 lines	0 comments	Download
M	ui/wm/core/shadow_types.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954123002/1

5 years, 10 months ago (2015-02-25 20:43:54 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 21:01:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cbc5df777caae32d4c48a5e22f389f4642994a0d
Cr-Commit-Position: refs/heads/master@{#318110}