Issue 455543004: Use ShadowController instead of creating its own.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455543004: Use ShadowController instead of creating its own. (Closed)

Created:
6 years, 4 months ago by oshima

Modified:
6 years, 4 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Use ShadowController instead of creating its own. Added SHADOW_TYPE_RECTANGULAR_ALWAYS_ACTIVE which lets the window always use the active shadow. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289153

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -47 lines)			Patch
M	athena/home/home_card_impl.cc	View		4 chunks	+5 lines, -26 lines	0 comments	Download
M	athena/wm/window_manager_impl.cc	View	1	6 chunks	+9 lines, -3 lines	0 comments	Download
M	athena/wm/window_overview_mode.cc	View	1	5 chunks	+3 lines, -13 lines	0 comments	Download
M	ui/wm/core/shadow_controller.cc	View		3 chunks	+19 lines, -5 lines	0 comments	Download
M	ui/wm/core/shadow_controller_unittest.cc	View		1 chunk	+54 lines, -0 lines	0 comments	Download
M	ui/wm/core/shadow_types.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/455543004/100001

6 years, 4 months ago (2014-08-12 21:45:29 UTC) #5

Message was sent while issue was closed.

Change committed as 289153