Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 952513002: Update gypi in extensions after move and removal of headers. (Closed)

Created:
5 years, 10 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update gypi in extensions after move and removal of headers. Fixes warnings in the gyp msvs-ninja generator. Followup to https://codereview.chromium.org/892923002 (guest_view_messages.h) https://codereview.chromium.org/913393003 (extension_view.js) https://codereview.chromium.org/820513002 (surface_worker.js, and surface_view.js) https://codereview.chromium.org/654043002 (web_view.js, web_view_events.js and web_view_experimental.js) R=fsamuel@chromium.org,kalman@chromium.org,apacible@chromium.org,rockot@chromium.org BUG=459058, 444869, 459680, 434226 Committed: https://crrev.com/400e3ecf9e6456f00c8626b33188933c63696941 Cr-Commit-Position: refs/heads/master@{#317767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M extensions/extensions.gypi View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Daniel Bratell
5 years, 10 months ago (2015-02-23 14:43:53 UTC) #1
Fady Samuel
lgtm
5 years, 10 months ago (2015-02-23 15:35:25 UTC) #2
apacible
lgtm
5 years, 10 months ago (2015-02-23 16:32:58 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-23 17:25:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952513002/1
5 years, 10 months ago (2015-02-23 17:35:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61734)
5 years, 10 months ago (2015-02-23 17:41:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952513002/1
5 years, 10 months ago (2015-02-24 08:32:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 08:46:26 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 08:46:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/400e3ecf9e6456f00c8626b33188933c63696941
Cr-Commit-Position: refs/heads/master@{#317767}

Powered by Google App Engine
This is Rietveld 408576698