Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 892923002: Move GuestView IPCs into their own messages file. (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GuestView IPCs into their own messages file. BUG=444869 Committed: https://crrev.com/a04a4483105ca6f5daadc992536e839ee2f6c18f Cr-Commit-Position: refs/heads/master@{#314233}

Patch Set 1 #

Patch Set 2 : Moved into a more sensible directory #

Total comments: 2

Patch Set 3 : Addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -61 lines) Patch
M extensions/browser/guest_view/guest_view_base.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/guest_view_message_filter.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M extensions/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/extension_message_generator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/extension_messages.h View 2 chunks +0 lines, -37 lines 0 comments Download
A extensions/common/guest_view/guest_view_messages.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_container.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Fady Samuel
5 years, 10 months ago (2015-02-02 06:09:06 UTC) #2
Fady Samuel
5 years, 10 months ago (2015-02-02 07:55:23 UTC) #4
lazyboy
lgtm https://codereview.chromium.org/892923002/diff/20001/extensions/common/guest_view/guest_view_messages.h File extensions/common/guest_view/guest_view_messages.h (right): https://codereview.chromium.org/892923002/diff/20001/extensions/common/guest_view/guest_view_messages.h#newcode5 extensions/common/guest_view/guest_view_messages.h:5: // IPC messages for extensions. s/extensions/Guest view
5 years, 10 months ago (2015-02-02 17:10:48 UTC) #5
Fady Samuel
+kalman@ for extensions OWNERs approval. +kenrb@ for _messages.h OWNER approval https://codereview.chromium.org/892923002/diff/20001/extensions/common/guest_view/guest_view_messages.h File extensions/common/guest_view/guest_view_messages.h (right): https://codereview.chromium.org/892923002/diff/20001/extensions/common/guest_view/guest_view_messages.h#newcode5 ...
5 years, 10 months ago (2015-02-02 20:55:25 UTC) #7
kenrb
lgtm
5 years, 10 months ago (2015-02-02 21:18:15 UTC) #8
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-02 22:51:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892923002/40001
5 years, 10 months ago (2015-02-02 22:55:41 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 01:29:55 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 01:30:45 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a04a4483105ca6f5daadc992536e839ee2f6c18f
Cr-Commit-Position: refs/heads/master@{#314233}

Powered by Google App Engine
This is Rietveld 408576698