Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 820513002: Renamed WorkerFrame to SurfaceWorker (Closed)

Created:
6 years ago by Fady Samuel
Modified:
6 years ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed WorkerFrame to SurfaceWorker To match the current naming, WorkerFrame has been renamed to SurfaceWorker <workerframe> has been renamed <surfaceview> BUG=434226 TBR=kalman@chromium.org trivial rename from workerframe to surfaceworker and surfaceview. Committed: https://crrev.com/89d8ecf9dd5c922f7fd78751a9bcdfd24fb0137f Cr-Commit-Position: refs/heads/master@{#309129}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed nit #

Patch Set 3 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -340 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + extensions/browser/guest_view/surface_worker/surface_worker_constants.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + extensions/browser/guest_view/surface_worker/surface_worker_constants.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + extensions/browser/guest_view/surface_worker/surface_worker_guest.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + extensions/browser/guest_view/surface_worker/surface_worker_guest.cc View 4 chunks +21 lines, -21 lines 0 comments Download
D extensions/browser/guest_view/worker_frame/worker_frame_constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
D extensions/browser/guest_view/worker_frame/worker_frame_constants.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D extensions/browser/guest_view/worker_frame/worker_frame_guest.h View 1 chunk +0 lines, -52 lines 0 comments Download
D extensions/browser/guest_view/worker_frame/worker_frame_guest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + extensions/common/api/surface_worker_internal.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
D extensions/common/api/worker_frame_internal.json View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M extensions/common/feature_switch.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/feature_switch.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/switches.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/extensions.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/extensions_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/resources/guest_view/surface_view.js View 2 chunks +9 lines, -9 lines 0 comments Download
D extensions/renderer/resources/guest_view/worker_frame.js View 1 chunk +0 lines, -50 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Fady Samuel
6 years ago (2014-12-18 21:58:51 UTC) #2
lazyboy
lgtm https://chromiumcodereview.appspot.com/820513002/diff/1/extensions/common/api/_api_features.json File extensions/common/api/_api_features.json (right): https://chromiumcodereview.appspot.com/820513002/diff/1/extensions/common/api/_api_features.json#newcode384 extensions/common/api/_api_features.json:384: "surfaceWorkerInternal": { Sort
6 years ago (2014-12-18 22:14:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820513002/20001
6 years ago (2014-12-18 22:41:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/16366)
6 years ago (2014-12-19 00:01:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820513002/40001
6 years ago (2014-12-19 01:06:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-19 02:11:58 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-19 02:13:35 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/89d8ecf9dd5c922f7fd78751a9bcdfd24fb0137f
Cr-Commit-Position: refs/heads/master@{#309129}

Powered by Google App Engine
This is Rietveld 408576698