Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 654043002: Created "guest_view/" directory to contain all the guestview files (like web_view* and app_view*) i… (Closed)

Created:
6 years, 2 months ago by paulmeyer
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Created "guest_view/" directory to contain all the guestview files (like web_view* and app_view*) in "extensions/renderer/resources/". The content of all moved files remains the same, with the exception of OWNERS. Committed: https://crrev.com/f4220a2bbad13b1bfaedad9dd5f38a0c4dc3231b Cr-Commit-Position: refs/heads/master@{#299563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -1939 lines) Patch
D extensions/renderer/resources/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/renderer/resources/app_view.js View 1 chunk +0 lines, -205 lines 0 comments Download
D extensions/renderer/resources/app_view_deny.js View 1 chunk +0 lines, -39 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 3 chunks +8 lines, -8 lines 0 comments Download
A + extensions/renderer/resources/guest_view/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/app_view.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/app_view_deny.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view_deny.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view_events.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view_experimental.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view_internal.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view_request_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/renderer/resources/web_view.js View 1 chunk +0 lines, -936 lines 0 comments Download
D extensions/renderer/resources/web_view_deny.js View 1 chunk +0 lines, -38 lines 0 comments Download
D extensions/renderer/resources/web_view_events.js View 1 chunk +0 lines, -606 lines 0 comments Download
D extensions/renderer/resources/web_view_experimental.js View 1 chunk +0 lines, -53 lines 0 comments Download
D extensions/renderer/resources/web_view_internal.js View 1 chunk +0 lines, -6 lines 0 comments Download
D extensions/renderer/resources/web_view_request_custom_bindings.js View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paulmeyer
+rockot@
6 years, 2 months ago (2014-10-14 19:43:13 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-14 20:47:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654043002/1
6 years, 2 months ago (2014-10-14 20:50:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 22:09:26 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 22:10:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4220a2bbad13b1bfaedad9dd5f38a0c4dc3231b
Cr-Commit-Position: refs/heads/master@{#299563}

Powered by Google App Engine
This is Rietveld 408576698