Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 952273003: Make WebView::close not crash and start to fix navigation in SkyShell (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make WebView::close not crash and start to fix navigation in SkyShell However WebView::close() no longer crashes. close() is never called in MojoShell since mojo can't shutdown yet. I tried closing the existing WebView and replacing it but somehow that caused it to only draw red. After a while of looking at this with abarth we decided to just load into the same WebView for now. Eventually we should do something smarter where we start the provisional load and only replace the webview once the new one is ready, but that's a later CL. R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/40c5d6474f79ce40036ef1d9780a5dc7b8c5f0ce

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -4 lines) Patch
M sky/engine/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/ui/animator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/shell/ui/animator.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M sky/shell/ui/engine.h View 3 chunks +14 lines, -0 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
5 years, 10 months ago (2015-02-25 22:30:59 UTC) #1
abarth-chromium
https://codereview.chromium.org/952273003/diff/1/sky/shell/ui/engine.cc File sky/shell/ui/engine.cc (right): https://codereview.chromium.org/952273003/diff/1/sky/shell/ui/engine.cc#newcode154 sky/shell/ui/engine.cc:154: LoadURL(request->url); We should do this asynchronously.
5 years, 10 months ago (2015-02-25 23:21:32 UTC) #2
eseidel
5 years, 10 months ago (2015-02-25 23:24:35 UTC) #3
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-25 23:25:11 UTC) #4
eseidel
5 years, 10 months ago (2015-02-25 23:25:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
40c5d6474f79ce40036ef1d9780a5dc7b8c5f0ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698