sky/engine/core/script/dart_controller.cc - Issue 952273003: Make WebView::close not crash and start to fix navigation in SkyShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/script/dart_controller.cc

Issue 952273003: Make WebView::close not crash and start to fix navigation in SkyShell (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Fixed Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/script/dart_controller.cc

diff --git a/sky/engine/core/script/dart_controller.cc b/sky/engine/core/script/dart_controller.cc

index 8e2a0608438e8157d3f1b58a3e1e9f1870078904..b440d420dd189d7a0b181b334a1b4b7520447089 100644

--- a/sky/engine/core/script/dart_controller.cc

+++ b/sky/engine/core/script/dart_controller.cc

@@ -284,7 +284,8 @@ void DartController::CreateIsolateFor(Document* document) {

}

void DartController::ClearForClose() {

- DartIsolateScope scope(dom_dart_state_->isolate());

+ // Don't use a DartIsolateScope here since we never exit the isolate.

+ Dart_EnterIsolate(dom_dart_state_->isolate());

Dart_ShutdownIsolate();

dom_dart_state_.clear();

}