Issue 950723003: [Push] Enable PushManager.hasPermission() in browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 950723003: [Push] Enable PushManager.hasPermission() in browser tests. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)

Modified:
5 years, 10 months ago

Reviewers:

CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, zea+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

[Push] Enable PushManager.hasPermission() in browser tests. Enables PushManager.hasPermission() as a transition until the Permissions API can be used in order to get that information. It will save a lot of trouble in changing the current test in order to no longer use hasPermission() then change them again to use the Permissions API. This is a three sided CL: 1- https://codereview.chromium.org/926793004 2- <this> 3- https://codereview.chromium.org/936873002 BUG=449178 TBR=sievers@chromium.org,mvanouwerkerk@chromium.org Review URL: https://codereview.chromium.org/937563004 Cr-Commit-Position: refs/heads/master@{#317512} (cherry picked from commit 6aa612689f8f19153c0ee3a6b1befa5650226a6f) Committed: https://chromium.googlesource.com/chromium/src/+/bfd5d829b8c7ebb3da0d34807c5beac9788f61da

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
M	chrome/browser/services/gcm/push_messaging_browsertest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/child/runtime_features.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

mlamouri (slow - plz ping)

5 years, 10 months ago (2015-02-25 10:51:25 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bfd5d829b8c7ebb3da0d34807c5beac9788f61da (presubmit successful).