Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 937563004: [Push] Enable PushManager.hasPermission() in browser tests. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Push] Enable PushManager.hasPermission() in browser tests. Enables PushManager.hasPermission() as a transition until the Permissions API can be used in order to get that information. It will save a lot of trouble in changing the current test in order to no longer use hasPermission() then change them again to use the Permissions API. This is a three sided CL: 1- https://codereview.chromium.org/926793004 2- <this> 3- https://codereview.chromium.org/936873002 BUG=449178 Committed: https://crrev.com/6aa612689f8f19153c0ee3a6b1befa5650226a6f Cr-Commit-Position: refs/heads/master@{#317512}

Patch Set 1 #

Patch Set 2 : use WebRuntimeFeatures #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-18 18:52:10 UTC) #2
Peter Beverloo
Can we perhaps attach another bug to these CLs in context of deciding whether it ...
5 years, 10 months ago (2015-02-18 20:23:03 UTC) #3
mlamouri (slow - plz ping)
On 2015/02/18 at 20:23:03, peter wrote: > Can we perhaps attach another bug to these ...
5 years, 10 months ago (2015-02-18 20:43:06 UTC) #5
Michael van Ouwerkerk
drive-by lgtm
5 years, 10 months ago (2015-02-19 10:26:43 UTC) #7
mlamouri (slow - plz ping)
+sievers@ for OWNERS review in content/
5 years, 10 months ago (2015-02-19 12:01:30 UTC) #9
no sievers
On 2015/02/19 12:01:30, Mounir Lamouri wrote: > +sievers@ for OWNERS review in content/ lgtm
5 years, 10 months ago (2015-02-19 19:10:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937563004/40001
5 years, 10 months ago (2015-02-19 19:41:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/60982) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 10 months ago (2015-02-19 19:51:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937563004/40001
5 years, 10 months ago (2015-02-20 11:35:23 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/61600)
5 years, 10 months ago (2015-02-20 11:58:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937563004/40001
5 years, 10 months ago (2015-02-21 13:18:16 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-21 14:21:56 UTC) #21
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 14:22:38 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6aa612689f8f19153c0ee3a6b1befa5650226a6f
Cr-Commit-Position: refs/heads/master@{#317512}

Powered by Google App Engine
This is Rietveld 408576698