Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 926793004: Add PushMessagingHasPermission runtime flag to expose PushManager.hasPermission() (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add PushMessagingHasPermission runtime flag to expose PushManager.hasPermission() We want to keep hasPermission() away from the Push API for now. The Permissions API will be used to fulfil that role. However, it is not ready yet so in the mean time, we want to still be able to test the feature until we move to the new version. This is part of a three-sided CL: 1- <this> 2- https://codereview.chromium.org/937563004 3- https://codereview.chromium.org/936873002 BUG=449178 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190471

Patch Set 1 #

Patch Set 2 : add WebRuntimeFeatures #

Patch Set 3 : stable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M Source/modules/push_messaging/PushManager.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-18 18:55:41 UTC) #2
Peter Beverloo
push lgtm. let's hope we can get rid of this code soon :-)
5 years, 10 months ago (2015-02-18 19:02:59 UTC) #4
Michael van Ouwerkerk
drive-by lgtm
5 years, 10 months ago (2015-02-19 10:26:36 UTC) #7
Mike West
LGTM.
5 years, 10 months ago (2015-02-19 10:34:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926793004/40001
5 years, 10 months ago (2015-02-19 12:09:45 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 14:05:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190471

Powered by Google App Engine
This is Rietveld 408576698