Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 936873002: Mark PushMessagingHasPermission as test only. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@push_disable_haspermission
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark PushMessagingHasPermission as test only. This is part of a three-sided CL: 1- https://codereview.chromium.org/926793004 2- https://codereview.chromium.org/937563004 3- <this> BUG=449178 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190619

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-18 20:18:49 UTC) #2
Peter Beverloo
On 2015/02/18 20:18:49, Mounir Lamouri wrote: push lgtm
5 years, 10 months ago (2015-02-18 20:21:14 UTC) #3
Michael van Ouwerkerk
drive-by lgtm
5 years, 10 months ago (2015-02-19 10:26:48 UTC) #5
Mike West
LGTM.
5 years, 10 months ago (2015-02-19 10:35:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936873002/1
5 years, 10 months ago (2015-02-21 14:45:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936873002/20001
5 years, 10 months ago (2015-02-21 17:40:03 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 20:03:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190619

Powered by Google App Engine
This is Rietveld 408576698