Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl. (Closed)

Created:
5 years, 10 months ago by Charlie Reis
Modified:
5 years, 10 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid unnecessary casts in NavigationControllerImpl. This will avoid further casts as we refactor session history for OOPIFs. BUG=236848 TEST=No behavior change. Committed: https://crrev.com/3da0387c8a32f82e18a289be66c4f8b46abd90bc Cr-Commit-Position: refs/heads/master@{#317402}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -248 lines) Patch
M content/browser/frame_host/navigation_controller_impl.h View 6 chunks +17 lines, -17 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 20 chunks +23 lines, -29 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 47 chunks +66 lines, -137 lines 0 comments Download
M content/browser/frame_host/navigation_entry_screenshot_manager.cc View 8 chunks +12 lines, -20 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 5 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Alex: Sorry, this one is a bit mechanical, but it cleans things up quite a ...
5 years, 10 months ago (2015-02-20 18:06:42 UTC) #2
alexmos
LGTM. Awesome cleanup!
5 years, 10 months ago (2015-02-20 19:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949473002/20001
5 years, 10 months ago (2015-02-20 19:33:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 21:12:49 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 21:13:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3da0387c8a32f82e18a289be66c4f8b46abd90bc
Cr-Commit-Position: refs/heads/master@{#317402}

Powered by Google App Engine
This is Rietveld 408576698