content/browser/web_contents/web_contents_impl.cc - Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/aura/overscroll_navigation_overlay.cc ('k') | content/browser/web_contents/web_contents_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 62deecd922ed2890dd26c19932aac7c34d2c72ea..ed679224852e6b4631a4335b32c695015be47e3e 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1960,8 +1960,7 @@ bool WebContentsImpl::NavigateToPendingEntry(

// is currently only used in --site-per-process and tests.

// TODO(creis): Remove this method and NavigationEntryImpl::frame_tree_node_id

// by using FrameNavigationEntries instead. See https://crbug.com/236848.

- NavigationEntryImpl* pending_entry =

- NavigationEntryImpl::FromNavigationEntry(controller_.GetPendingEntry());

+ NavigationEntryImpl* pending_entry = controller_.GetPendingEntry();

if (pending_entry->frame_tree_node_id() != -1) {

FrameTreeNode* subframe =

frame_tree_.FindByID(pending_entry->frame_tree_node_id());