Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 547c5515f8f740f20db596244f4265a34057b461..d31a65a584e505806ba9429ae0f49594cae93f92 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -191,8 +191,7 @@ void NavigatorImpl::DidStartProvisionalLoad(
render_process_host->FilterURL(false, &validated_url);
bool is_main_frame = render_frame_host->frame_tree_node()->IsMainFrame();
- NavigationEntryImpl* pending_entry =
- NavigationEntryImpl::FromNavigationEntry(controller_->GetPendingEntry());
+ NavigationEntryImpl* pending_entry = controller_->GetPendingEntry();
if (is_main_frame) {
// If there is no browser-initiated pending entry for this navigation and it
// is not for the error URL, create a pending entry using the current
@@ -421,10 +420,8 @@ bool NavigatorImpl::NavigateToEntry(
bool NavigatorImpl::NavigateToPendingEntry(
FrameTreeNode* frame_tree_node,
NavigationController::ReloadType reload_type) {
- return NavigateToEntry(
- frame_tree_node,
- *NavigationEntryImpl::FromNavigationEntry(controller_->GetPendingEntry()),
- reload_type);
+ return NavigateToEntry(frame_tree_node, *controller_->GetPendingEntry(),
+ reload_type);
}
void NavigatorImpl::DidNavigate(
« no previous file with comments | « content/browser/frame_host/navigation_entry_screenshot_manager.cc ('k') | content/browser/ssl/ssl_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698