content/browser/web_contents/aura/overscroll_navigation_overlay.cc - Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay.cc

Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/aura/overscroll_navigation_overlay.cc

diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

index 89aa4975f81a12b870ddd544c3dff67a96bc2561..a96b0d27ed66cd46912ebc7d55fdee0feb5e9f9c 100644

--- a/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

@@ -208,8 +208,7 @@ void OverscrollNavigationOverlay::StopObservingIfDone() {

ui::Layer* OverscrollNavigationOverlay::CreateSlideLayer(int offset) {

const NavigationControllerImpl& controller = web_contents_->GetController();

- const NavigationEntryImpl* entry = NavigationEntryImpl::FromNavigationEntry(

- controller.GetEntryAtOffset(offset));

+ const NavigationEntryImpl* entry = controller.GetEntryAtOffset(offset);

gfx::Image image;

if (entry && entry->screenshot().get()) {

« no previous file with comments | « content/browser/ssl/ssl_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »